Skip to content

Remove the workarounds for some resolved issues #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove the workarounds for some resolved issues #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68810af
Re-enable `armv7-unknown-linux-gnueabihf`
sayantn Apr 13, 2025
62ff5cc
Remove workarounds for llvm/llvm-project#98306
sayantn Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ci/dox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ dox() {
if [ -z "$1" ]; then
dox i686-unknown-linux-gnu
dox x86_64-unknown-linux-gnu
# Disabled temporarily,
# See https://github.com/rust-lang/rust/issues/134511
#dox armv7-unknown-linux-gnueabihf
dox armv7-unknown-linux-gnueabihf
dox aarch64-unknown-linux-gnu
dox powerpc-unknown-linux-gnu
dox powerpc64le-unknown-linux-gnu
Expand Down
20 changes: 14 additions & 6 deletions crates/core_arch/src/x86/avx512fp16.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4563,9 +4563,13 @@ pub fn _mm_maskz_fmadd_round_sch<const ROUNDING: i32>(
) -> __m128h {
unsafe {
static_assert_rounding!(ROUNDING);
let a = transmute(a);
let r = vfmaddcsh_maskz(a, transmute(b), transmute(c), k, ROUNDING);
transmute(_mm_move_ss(a, r)) // FIXME: If `k == 0`, then LLVM optimized `vfmaddcsh_maskz` to output an all-zero vector, which is incorrect
transmute(vfmaddcsh_maskz(
transmute(a),
transmute(b),
transmute(c),
k,
ROUNDING,
))
}
}

Expand Down Expand Up @@ -5108,9 +5112,13 @@ pub fn _mm_maskz_fcmadd_round_sch<const ROUNDING: i32>(
) -> __m128h {
unsafe {
static_assert_rounding!(ROUNDING);
let a = transmute(a);
let r = vfcmaddcsh_maskz(a, transmute(b), transmute(c), k, ROUNDING);
transmute(_mm_move_ss(a, r)) // FIXME: If `k == 0`, then LLVM optimized `vfcmaddcsh_maskz` to output an all-zero vector, which is incorrect
transmute(vfcmaddcsh_maskz(
transmute(a),
transmute(b),
transmute(c),
k,
ROUNDING,
))
}
}

Expand Down