Convert all uses of llvm_asm! to asm! #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amanieu: no appropriate reviewer found, use r? to override |
|
Blocked on rust-lang/rust#82838 |
Amanieu
force-pushed
the
asm
branch
5 times, most recently
from
0f54977 to
bb36916
Compare
This was referenced Mar 9, 2021
|
@Amanieu This was the first time I saw something converted from the old style inline asm to the new style that you and the inline asm group designed. It looks like an order of magnitude improvement in clarity to me. Amazing work. :-) |
bors bot
added a commit
to rust-embedded/riscv
that referenced
this pull request
Aug 12, 2021
86: feat: Use new asm! instead of llvm_asm! r=Disasm a=duskmoon314 The new `asm` macro has been merged into `nightly` for some time, while `llvm_asm` will be gradually deprecated and will not enter `stable`. This PR replaces `llvm_asm` with `asm`, but there are still some minor issues to discuss. My reference are: - [asm feature](https://doc.rust-lang.org/unstable-book/library-features/asm.html) - [arch/cortex-m: change a few llvm_asm!s to asm!s](tock/tock#2092) - [Convert all uses of llvm_asm! to asm!](rust-lang/stdarch#1052) --- In the new `asm` feature, there are several options can set to optimize codes. [options](https://doc.rust-lang.org/unstable-book/library-features/asm.html#options-1) However, I'm not quite sure which options to set. (Sort of newbie to asm in rust) Co-authored-by: Campbell He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #904