Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add automatic publish on tag creation #88

Merged
merged 1 commit into from
Jun 25, 2024
Merged

CI: Add automatic publish on tag creation #88

merged 1 commit into from
Jun 25, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jun 24, 2024 •
edited
Loading

@syphar syphar marked this pull request as ready for review June 24, 2024 08:35
@syphar
Copy link
Member Author

syphar commented Jun 24, 2024

r? @Kobzol

@Kobzol
Copy link

Kobzol commented Jun 24, 2024

The workflow looks fine to me, but I don't have the permissions to configure the token. We can discuss this at today's infra meeting.

@Kobzol Kobzol requested a review from jdno June 24, 2024 10:25
jdno
jdno approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created the token and added it as a repository secret. 👍

@syphar syphar merged commit 76bac8d into rust-lang:master Jun 25, 2024
5 checks passed
@syphar syphar deleted the automate-release branch June 25, 2024 12:48
@syphar
Copy link
Member Author

syphar commented Jun 25, 2024

thank you @jdno !

@Kobzol Kobzol mentioned this pull request Jun 25, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdno jdno jdno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syphar @Kobzol @jdno