Add Config::run_subprocess_cmd
#4202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `Config::run_subprocess` takes a program name and a list of arguments, constructs a command from them, and then runs the command. The function this commit adds is similar, but it accepts an already constructed command. Extracted from rust-lang#4175
rami3l
previously approved these changes
Mar 2, 2025
rami3l
dismissed
their stale review
After another look, I'm now slightly inclined to rejecting this for two reasons:
- Without the original patch, this extra public API serves no purpose. (PS: In previous reviews @djc seems to be strongly against dangling APIs, and, they should be inlined if they don't represent a recurring pattern.)
- If we were to merge this, I guess the
#[track_caller]should be moved to.run_subprocess_cmd(), however this has added an extra layer of indirection everywhere. Of course, this point will remain debatable if it represents a real use case.
|
I won't be insulted if you reject this. Thank you for merging the other three. :) |
|
Yeah, by itself this doesn't seem a clear improvement. Thanks for your contributions, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
Config::run_subprocesstakes a program name and a list of arguments, constructs a command from them, and then runs the command.The function this commit adds is similar, but it accepts an already constructed command.
Extracted from #4175