Skip to content

Do not append EXE_SUFFIX in Config::cmd #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Mar 1, 2025

Previously, Config::cmd would always append an EXE_SUFFIX. However, this would produce an invalid path if the suffix was already present.

Extracted from #4175

Previously, `Config::cmd` would always append an `EXE_SUFFIX`. However,
this would produce an invalid path if the suffix was already present.

Extracted from rust-lang#4175
@rami3l
Copy link
Member

rami3l commented Mar 2, 2025

Note

See 2d94925 (#4175) for the full context: it's about extracting a binary path from elsewhere and running it in Config::cmd().

I believe this is something that we should support and, on Windows, it's a real bug fix, since IIRC it does support foo and foo.exe as valid references to foo.exe (all our previous tests called it foo which at this step will become foo.exe), but foo.exe.exe is a hard error.

@rami3l rami3l added this pull request to the merge queue Mar 2, 2025
Merged via the queue into rust-lang:master with commit f41403f Mar 2, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants