Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare deployment on master branch #3931

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

jdno
Copy link
Member

@jdno jdno commented Jul 9, 2024

We added steps to the GitHub Actions workflows in #3909 to upload the build artifacts for the master branch as well as for the stable branch. But the scripts that prepare the deploy/ directory were not set to run on master, causing the builds to fail.

We added steps to the GitHub Actions workflows in rust-lang#3909 to upload the
build artifacts for the `master` branch as well as for the `stable`
branch. But the scripts that prepare the `deploy/` directory were not
set to run on `master`, causing the builds to fail.
@rami3l
Copy link
Member

rami3l commented Jul 9, 2024

@jdno Just being curious: will this allow some sort of publicly available "thunk" builds? Because that will also be a good move towards better transparency if it does :)

@jdno jdno added this pull request to the merge queue Jul 9, 2024
@jdno
Copy link
Member Author

jdno commented Jul 9, 2024

Do you mean that users will be able to install builds from the master branch? We haven't thought about it yet, but I see no reason why we can't make the S3 bucket publicly available so that users can do something like RUSTUP_UPDATE_ROOT=https://builds.rustup.rs/${commit} rustup self update (or another domain)... 🤔

@rami3l
Copy link
Member

rami3l commented Jul 9, 2024

Do you mean that users will be able to install builds from the master branch? We haven't thought about it yet, but I see no reason why we can't make the S3 bucket publicly available so that users can do something like RUSTUP_UPDATE_ROOT=https://builds.rustup.rs/${commit} rustup self update (or another domain)... 🤔

@jdno Yup! I had to provide CI uploads to users in order to know if some recent fix has worked for them or not (e.g. #3708 (comment)). This would be a nice addition if possible, and it seems that there shouldn't be introducing too much overhead for you?

Moved to #3932.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2024
@rami3l rami3l added this pull request to the merge queue Jul 9, 2024
Merged via the queue into rust-lang:master with commit 8c76204 Jul 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants