Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rls and rust-analysis from components list. #3410

Closed
wants to merge 0 commits into from
Closed

Remove rls and rust-analysis from components list. #3410

wants to merge 0 commits into from

Conversation

burakemir
Copy link
Contributor

@burakemir burakemir commented Jul 17, 2023

This is a documentation-only change.

Since rls and rust-analysis do not seem to be useful, removing those from the component list.

RLS was deprecated over a year ago. https://blog.rust-lang.org/2022/07/01/RLS-deprecation.html
The rust-analysis component seems to only contain a placeholder file with the contents

{"warning": "The `rust-analysis` component has been removed." }"

I checked a few occurrences in rustup toolchain manifest files, and they only seem to contain that "removed.json".

I believe no one will miss these things.

@Rustin170506
Copy link
Member

cc: #3316

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Rustin170506
Copy link
Member

@burakemir Please rebase your branch with the latest master branch to fix the test.

@Rustin170506 Rustin170506 requested a review from rbtcollins July 18, 2023 23:54
@rbtcollins
Copy link
Contributor

I think we should rearrange rather than remove these entries. Rustup installs both current and old versions of toolchains, and those components remain valid in older releases: the removal only affects newer channel metadata, not existing.

Something like

### Previous components

These components have been deprecated and are not published in new Rust releases.

<table here>

Copy link
Contributor

@rbtcollins rbtcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in my other comment

@burakemir
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants