Skip to content

Make some of rust-timer's GitHub messages more succinct #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

miikkas
Copy link
Contributor

@miikkas miikkas commented Jun 5, 2025

Some initial feedback would be helpful. :)

Fixes: #2149

@miikkas
Copy link
Contributor Author

miikkas commented Jun 5, 2025

A mock example of the current difference:

Before

rust-timer-try-run-hidden-summaries-before

After

rust-timer-try-run-hidden-summaries-after

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! I like how you compressed the sentences without changing their meaning. I'm fine with merging modulo one comment.

@miikkas miikkas marked this pull request as ready for review June 5, 2025 17:41
@miikkas
Copy link
Contributor Author

miikkas commented Jun 5, 2025

Looks really great! I like how you compressed the sentences without changing their meaning. I'm fine with merging modulo one comment.

Thanks! The comment has been solved, and I've marked the PR ready.

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kobzol Kobzol merged commit 6cc9025 into rust-lang:master Jun 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More succinct GitHub comments for rust-timer
2 participants