Skip to content

Update html5ever to 0.31.0 #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Update html5ever to 0.31.0 #2069

merged 2 commits into from
Apr 15, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 14, 2025 •
edited
Loading

The total build is faster, as there are ~10 less dependencies, while the leaf crate has ~10% more executed instructions.

time -p CARGO_INCREMENTAL=0 cargo check ; cargo clean
# 5.16
# 4.23

time -p CARGO_INCREMENTAL=0 cargo build ; cargo clean
# 5.5
# 4.4

time -p CARGO_INCREMENTAL=0 cargo build --release ; cargo clean
# 5.9
# 4.7

Related issue: #2024

@Kobzol Kobzol requested a review from nnethercote April 14, 2025 10:13
@Kobzol Kobzol mentioned this pull request Apr 14, 2025
Open
40 tasks
@Kobzol Kobzol added the benchmark-update PR that updates the benchmark set. label Apr 14, 2025
@nnethercote
Copy link
Contributor

Looks good except for the whitespace changes in README.md.

@Kobzol Kobzol force-pushed the update-html5ever branch from 1ffdbaa to b42fa75 Compare April 14, 2025 12:31
@Kobzol Kobzol merged commit 7801fd1 into rust-lang:master Apr 15, 2025
11 checks passed
@Kobzol Kobzol deleted the update-html5ever branch April 15, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees
No one assigned
Labels
benchmark-update PR that updates the benchmark set.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @nnethercote