-
Notifications
You must be signed in to change notification settings - Fork 153
Update cc for remaining lockfiles #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
489f035
to
e47d49a
Compare
this is a very huge diff. I'll try to update crates for each package manually |
e47d49a
to
65cd677
Compare
@Kobzol sorry for disturbing with my attempts on making opt-dist work for specific host. I tried to minimize diff here, but I didn't manage to win cargo in fight with cc update for cargo-0.60.0 (it updates cc to >=v1.1.10 only with full lockfile update) edit: done, minimized the diff :) |
65cd677
to
791012b
Compare
Hmm, I have much bigger issue with this than the previous PR :) We only update the compile benchmarks if they stop compiling on our supported targets (which is right pretty much only x64 Linux), to keep benchmark stability. I don't want to do these global lockfile updates for the benchmarks in a single PR. That being said, we are currently just before a big benchmark update that will update most of the benchmarks to newer versions, which should also bump cc. So after that update the situation might be better for your target. The update will take at least several weeks though (and someone actually has to start doing it..). |
understood. I'll use my patch downstream then. waiting for updates |
I forgot to update cc in compile-benchmarks crates. when I tried to do so, I found that not all packages got rquired version of cc (>=1.1.10), so I manually updated cc in each package
791012b
to
307ecf2
Compare
by the way, when you open a PR with compile-benchmark, please mork your PR with |
There will probably be ~50 of such PRs (we need on PR to add a new benchmark and then later to remove the old one). I created a |
I forgot to update cc in compile-benchmarks crates. when I tried to do so, I found that not all packages got rquired version of cc (>=1.1.10), so I just blibfly ran
cargo update
for all packages to guarantee fresh version of cc...