Update docs related to const-eval/Miri #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Apr 18, 2020
|
ping @JohnTitor any updates? |
|
Sorry for the delay, all! I really busy with some other work, and I've finally got time to update here recently. |
JohnTitor
changed the title
JohnTitor
changed the title
RalfJung
reviewed
May 23, 2020
RalfJung
reviewed
May 23, 2020
src/const-eval.md
Outdated
| used) and a `GlobalId`. The `GlobalId` is made up of an | ||
| `Instance` referring to a constant or static or of an | ||
| `Instance` of a function and an index into the function's `Promoted` table. | ||
| The `const_eval_*` queries use a [`ParamEnv`](./param_env.html) of environment |
There was a problem hiding this comment.
I assume you mean const_eval_poly and friends? These are not queries, they are just wrappers around the const_eval query.
There was a problem hiding this comment.
Yeah, and I didn't know that. I updated this wording because someone was confused that const_eval doesn't exist on the docs anymore. Addressed via 852baf5.
RalfJung
reviewed
May 25, 2020
Co-authored-by: Ralf Jung <[email protected]>
RalfJung
reviewed
May 25, 2020
Co-authored-by: Ralf Jung <[email protected]>
RalfJung
approved these changes
May 25, 2020
|
Thanks @RalfJung for detailed reviews! I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to update
tcx.const_evalsince it was separated into sometcx.const_eval_*queries.The
const-evalchapter is relatively short. But about themirichapter, I'm totally not sure how we evaluate consts in Miri now instead oftcx.const_eval.I just replaced
tcx.const_evalwithtcx.const_eval_*but I guess we could specify the query that we actually use in some places.r? @oli-obk @RalfJung