Implement #[rustc_default_body_unstable]
#96478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
WaffleLapkin
commented
Apr 27, 2022
src/test/ui/stability-attribute/default-body-stability-err.stderr
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
rustc_default_body_unstable
branch
3 times, most recently
from
4d1cee1 to
35a5566
Compare
|
☔ The latest upstream changes (presumably #97177) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping from triage: |
WaffleLapkin
force-pushed
the
rustc_default_body_unstable
branch
2 times, most recently
from
67118a6 to
6d86e5d
Compare
danielhenrymantilla
approved these changes
Jun 20, 2022
|
☔ The latest upstream changes (presumably #95956) made this pull request unmergeable. Please resolve the merge conflicts. |
WaffleLapkin
force-pushed
the
rustc_default_body_unstable
branch
from
6d86e5d to
78eb420
Compare
This attribute allows to mark default body of a trait function as
unstable. This means that implementing the trait without implementing
the function will require enabling unstable feature.
This is useful in conjunction with `#[rustc_must_implement_one_of]`,
we may want to relax requirements for a trait, for example allowing
implementing either of `PartialEq::{eq, ne}`, but do so in a safe way
-- making implementation of only `PartialEq::ne` unstable.
WaffleLapkin
force-pushed
the
rustc_default_body_unstable
branch
from
78eb420 to
1e1d6fe
Compare
|
Sorry for the extreme delay - I had forgotten that this was assigned to me. This looks good to me overall - do we need lang-team signoff before adding this? |
Aaron1011
reviewed
Jul 29, 2022
Aaron1011
reviewed
Jul 29, 2022
I don't know, maybe 😄 |
|
r=me after confirmation from the libs teem that this is okay (or after an FCP if needed) |
Aaron1011
reviewed
Aug 5, 2022
|
@Aaron1011 why libs team approval is needed? This PR doesn't change any library APIs after all. Quoting
|
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#96478 (Implement `#[rustc_default_body_unstable]`) - rust-lang#99787 (Rustdoc-Json: Document HRTB's on DynTrait) - rust-lang#100181 (add method to get the mutability of an AllocId) - rust-lang#100221 (Don't document impossible to call default trait items on impls) - rust-lang#100228 (Don't ICE while suggesting updating item path.) - rust-lang#100301 (Avoid `&str` to `String` conversions) - rust-lang#100305 (Suggest adding an appropriate missing pattern excluding comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new stability attribute —
#[rustc_default_body_unstable].#[rustc_default_body_unstable]controls the stability of default bodies in traits.For example:
In order to implement
Traituser needs to eitheritem(even though it has a default implementation)#![feature(feat)]This is useful in conjunction with
#[rustc_must_implement_one_of], we may want to relax requirements for a trait, for example allowing implementing either ofPartialEq::{eq, ne}, but do so in a safe way — making implementation of onlyPartialEq::neunstable.r? @Aaron1011
cc @nrc (iirc you were interested in this wrt
read_buf), @danielhenrymantilla (you were interested in the related#[rustc_must_implement_one_of])P.S. This is my first time working with stability attributes, so I'm not sure if I did everything right 😅