-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update LLVM submodule #91657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LLVM submodule #91657
Conversation
r? @cuviper (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue Merge functions changes may have compile-time impact. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 017f6b7 with merge 0f5562d0b97f9a6a7ce71c15bc596ea6be63626b... |
☀️ Try build successful - checks-actions |
Queued 0f5562d0b97f9a6a7ce71c15bc596ea6be63626b with parent abba5ed, future comparison URL. |
Finished benchmarking commit (0f5562d0b97f9a6a7ce71c15bc596ea6be63626b): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
The |
The regression here is expected in that we perform function merging later -- this means that we merge more functions, but also that we process more duplicate functions until that point. Function merging is currently intended as a code size optimization rather than a compile-time optimization, though it may be worthwhile to investigate adding an additional MergeFunctions run early in the pipeline. @cuviper The LLVM side test case is basically just the IR from the report in #91490. I can add that as a codegen test here as well. |
@bors r+ |
📌 Commit e860f8e has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (06a6674): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Update LLVM submodule with recent cherry-picks. In particular: