Skip to content

Update LLVM submodule #91657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Update LLVM submodule #91657

merged 2 commits into from
Dec 13, 2021

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 8, 2021

@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2021
@nikic
Copy link
Contributor Author

nikic commented Dec 8, 2021

@bors try @rust-timer queue

Merge functions changes may have compile-time impact.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Dec 8, 2021

⌛ Trying commit 017f6b7 with merge 0f5562d0b97f9a6a7ce71c15bc596ea6be63626b...

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2021
@bors
Copy link
Collaborator

bors commented Dec 8, 2021

☀️ Try build successful - checks-actions
Build commit: 0f5562d0b97f9a6a7ce71c15bc596ea6be63626b (0f5562d0b97f9a6a7ce71c15bc596ea6be63626b)

@rust-timer
Copy link
Collaborator

Queued 0f5562d0b97f9a6a7ce71c15bc596ea6be63626b with parent abba5ed, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f5562d0b97f9a6a7ce71c15bc596ea6be63626b): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

  • Moderate regression in instruction counts (up to 1.0% on incr-full builds of deeply-nested-closures)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2021
@cuviper
Copy link
Member

cuviper commented Dec 8, 2021

The MergeFunctions change was for #91490 -- do you have a testcase to prove its worth?
(Then we can better justify the regression...)

@nikic
Copy link
Contributor Author

nikic commented Dec 8, 2021

The regression here is expected in that we perform function merging later -- this means that we merge more functions, but also that we process more duplicate functions until that point. Function merging is currently intended as a code size optimization rather than a compile-time optimization, though it may be worthwhile to investigate adding an additional MergeFunctions run early in the pipeline.

@cuviper The LLVM side test case is basically just the IR from the report in #91490. I can add that as a codegen test here as well.

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 9, 2021
@cuviper
Copy link
Member

cuviper commented Dec 9, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 9, 2021

📌 Commit e860f8e has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2021
@bors
Copy link
Collaborator

bors commented Dec 13, 2021

⌛ Testing commit e860f8e with merge 06a6674...

@bors
Copy link
Collaborator

bors commented Dec 13, 2021

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 06a6674 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 13, 2021
@bors bors merged commit 06a6674 into rust-lang:master Dec 13, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 13, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (06a6674): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rustbot rustbot removed the perf-regression Performance regression. label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants