Skip to content

Add missing impls field to typedef #89272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/librustdoc/json/conversions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,11 @@ crate fn from_macro_kind(kind: rustc_span::hygiene::MacroKind) -> MacroKind {
impl FromWithTcx<clean::Typedef> for Typedef {
fn from_tcx(typedef: clean::Typedef, tcx: TyCtxt<'_>) -> Self {
let clean::Typedef { type_, generics, item_type: _ } = typedef;
Typedef { type_: type_.into_tcx(tcx), generics: generics.into_tcx(tcx) }
Typedef {
type_: type_.into_tcx(tcx),
generics: generics.into_tcx(tcx),
impls: Vec::new(), // Added in JsonRenderer::item
}
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/librustdoc/json/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ impl<'tcx> FormatRenderer<'tcx> for JsonRenderer<'tcx> {
e.impls = self.get_impls(id.expect_def_id())
} else if let types::ItemEnum::Union(ref mut u) = new_item.inner {
u.impls = self.get_impls(id.expect_def_id())
} else if let types::ItemEnum::Typedef(ref mut t) = new_item.inner {
t.impls = self.get_impls(id.expect_def_id())
}
let removed = self.index.borrow_mut().insert(from_item_id(id), new_item.clone());

Expand Down Expand Up @@ -236,7 +238,7 @@ impl<'tcx> FormatRenderer<'tcx> for JsonRenderer<'tcx> {
)
})
.collect(),
format_version: 7,
format_version: 8,
};
let mut p = self.out_path.clone();
p.push(output.index.get(&output.root).unwrap().name.clone().unwrap());
Expand Down
1 change: 1 addition & 0 deletions src/rustdoc-json-types/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ pub struct Typedef {
#[serde(rename = "type")]
pub type_: Type,
pub generics: Generics,
pub impls: Vec<Id>,
}

#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
Expand Down
12 changes: 12 additions & 0 deletions src/test/rustdoc-json/typedefs/type_impl.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#![no_std]

// @has type_impl.json "$.index[*][?(@.name=='Ix')].visibility" \"public\"
// @has - "$.index[*][?(@.name=='Ix')].kind" \"typedef\"
pub type Ix = usize;

// @has - "$.index[*][?(@.name=='IxTrait')].visibility" \"public\"
// @has - "$.index[*][?(@.name=='IxTrait')].kind" \"trait\"
pub trait IxTrait {}

// @count - "$.index[*][?(@.name=='Ix')].inner.impls" 1
impl IxTrait for Ix {}