rustbuild: take changes to the standard library into account for download-rustc
#85996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-bootstrap
rust-highfive
added
the
S-waiting-on-review
|
In particular, this came up in #84942, where I changed the html_root_url for libstd and stumbled around rustdoc for a while thinking the bug was there. |
This comment has been minimized.
This comment has been minimized.
…nload-rustc` Previously, changing the standard library with `download-rustc = "if-unchanged"` would incorrectly reuse the cached compiler and standard library from CI, which was confusing and led to incorrect test failures or successes.
|
@bors r+ My guess is this may also not be quite enough (e.g., src/version and some other files also play a role in compiler behavior). But identifying the set of files that matter may be tough. Unfortunately it doesn't seem like there's really a great way to isolate that list easily. |
|
📌 Commit 261d16a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#84262 (Fix ICE during type layout when there's a `[type error]`) - rust-lang#85973 (Replace a `match` with an `if let`) - rust-lang#85996 (rustbuild: take changes to the standard library into account for `download-rustc`) - rust-lang#86016 (Unify duplicate linker_and_flavor methods in rustc_codegen_{cranelift,ssa}.) - rust-lang#86025 (Remove the install prefix from the rpath set when using -Crpath) - rust-lang#86081 (Use `try_into` instead of asserting manually) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, changing the standard library with
download-rustc = "if-unchanged"would incorrectly reuse the cached compiler and standardlibrary from CI, which was confusing and led to incorrect test failures
or successes.
r? @Mark-Simulacrum