Skip to content

Updated the help message to reduce the error iterations #79403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

bishtpawan
Copy link
Contributor

@bishtpawan bishtpawan commented Nov 25, 2020

Fixed issue #77270

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2020
@bishtpawan
Copy link
Contributor Author

bishtpawan commented Nov 27, 2020

Hi @Mark-Simulacrum, do you have any idea about log details? I'm unable to get the failure details.

Thanks

@Mark-Simulacrum
Copy link
Member

I suspect you may have made an error when making the PR or interacting with git -- it looks like you've only added changes to stderr files in the test suite, but the files the compiler is running on have not been changed. Resolving #77270 would require changing the compiler source code to provide the necessary hint to import the trait as well; I suspect doing so only when needed might be hard, though, and I'm not personally familiar with that area of the compiler so can't guide you. If you'd like to seek mentoring, though, posting on #t-compiler/help would be a good start.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2020
@crlf0710
Copy link
Member

@bishtpawan Ping from triage, CI is still red here. Would you mind fixing that? Thanks.

@bishtpawan
Copy link
Contributor Author

I commented on the issue regarding the issue but didn't get any response from the issue's owner. Still waiting for @follower's response. Thanks

@crlf0710
Copy link
Member

crlf0710 commented Jan 15, 2021

@bishtpawan Ping from triage, CI is still red here.

Maybe you can try ./x.py test --bless to update the expected test suite output (and review them before submitting to make sure these are wanted change).

@tesuji
Copy link
Contributor

tesuji commented Jan 15, 2021

@bishtpawan You have to change the actual code that emits the error messages. In this case

let msg = format!("{} and panic if the converted value doesn't fit", msg);

@bishtpawan bishtpawan closed this Jan 18, 2021
@bishtpawan
Copy link
Contributor Author

Closing this PR, for now, will raise a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants