Skip to content

Remove the full-bootstrap builder from CI #75708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #75198

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020
@JohnTitor
Copy link
Member Author

r? @pietroalbini

@pietroalbini
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2020

📌 Commit b985c29 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2020
@ehuss
Copy link
Contributor

ehuss commented Aug 19, 2020

Just to be clear, is the full-bootstrap option in config.toml broken? If so, should it be fixed? Or should it be removed? Or should it be documented as being broken?

@pietroalbini
Copy link
Member

Hmm, @Mark-Simulacrum?

@Mark-Simulacrum
Copy link
Member

I am uncertain, but I personally would be in favor of removing support for it. I don't personally think it useful (which is why I'm fine with dropping tests for it).

@JohnTitor
Copy link
Member Author

I am uncertain, but I personally would be in favor of removing support for it. I don't personally think it useful (which is why I'm fine with dropping tests for it).

I'm happy to remove it too. But it should be in another PR as it may need some discussion and/or some other eyes, right?

@Mark-Simulacrum
Copy link
Member

Yep, this PR is good to go. I will need to think some more on the general fate of full-bootstrap.

@bors
Copy link
Collaborator

bors commented Aug 21, 2020

⌛ Testing commit b985c29 with merge de521cb...

@bors
Copy link
Collaborator

bors commented Aug 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing de521cb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2020
@bors bors merged commit de521cb into rust-lang:master Aug 21, 2020
@JohnTitor JohnTitor deleted the stay-cool-full-bootstrap-builder branch August 21, 2020 19:52
@bors bors mentioned this pull request Aug 21, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full-bootstrap builder doesn't test anything
8 participants