Skip to content

Conversation

lqd
Copy link
Member

@lqd lqd commented Feb 26, 2020

Since @AlbinS won't have the time to finish up #68993 for a while, I'll take care of the trivial remaining tasks (rebasing, taking care of tidy/rustfmt).

I'll r? @nikomatsakis since they're assigned to #68993, but have actually already reviewed it pre-rebase.

When CI passes: I'll notify bors and close #68993, since this PR supersedes it.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2020
@lqd
Copy link
Member Author

lqd commented Feb 26, 2020

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Feb 26, 2020

📌 Commit 356d99b14421fbd09f5809ef0c1e169440eb26a6 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2020
@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2020
@lqd

This comment has been minimized.

@bors

This comment has been minimized.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2020
- update polonius-engine dependency to 0.12.0

- rustfmt the files failing tidy
@lqd
Copy link
Member Author

lqd commented Feb 27, 2020

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Feb 27, 2020

📌 Commit 6f40cdb has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented Mar 3, 2020

⌛ Testing commit 6f40cdb with merge b135c73...

@bors
Copy link
Collaborator

bors commented Mar 3, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing b135c73 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2020
@bors bors merged commit b135c73 into rust-lang:master Mar 3, 2020
@lqd lqd deleted the poloniusup branch March 3, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants