Switch AppVeyor to the standard Visual Studio 2017 image #61972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using the preview image but there doesn't seem to be a reason why, as the commit that originally added it didn't replace the standard image, but just used the preview from the start. AppVeyor Support recommended switching to the standard image in this support thread: https://help.appveyor.com/discussions/problems/24057-build-job-has-failed-to-start-but-backup-cloud-is-not-configured#comment_47365011
rust-highfive
added
the
S-waiting-on-review
|
@bors p=1 |
|
@bors: r+ |
|
📌 Commit 13dc0ba has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 13dc0ba with merge fda46cd67a51d55db8fa95a839e72d3aa26e2597... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Failure log: failures:
---- [debuginfo-gdb+lldb] debuginfo\basic-types-globals-metadata.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 800
NOTE: compiletest thinks it is using LLDB without native rust support
error: Error while running LLDB
status: exit code: 1
command: "C:\\Python27\\python2.7" "C:\\projects\\rust\\src/etc/lldb_batchmode.py" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\test\\debuginfo\\basic-types-globals-metadata\\a.exe" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\test\\debuginfo\\basic-types-globals-metadata\\basic-types-globals-metadata.debugger.script"
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
Traceback (most recent call last):
File "C:\projects\rust\src/etc/lldb_batchmode.py", line 17, in <module>
import lldb
ImportError: No module named lldb
------------------------------------------ |
|
Hm I don't believe we should be running LLDB tests on Windows, so some auto-detection may be automatically enabling them and we'll need to disable that on the CI builders. |
bors
added a commit
that referenced
this pull request
Jun 21, 2019
Switch AppVeyor to the standard Visual Studio 2017 image We were previously using the preview image but there doesn't seem to be a reason why, as the commit that originally added it didn't replace the standard image, but just used the preview from the start. AppVeyor Support recommended switching to the standard image [in this support thread](https://help.appveyor.com/discussions/problems/24057-build-job-has-failed-to-start-but-backup-cloud-is-not-configured#comment_47365011). r? @alexcrichton fixes #61931
|
💔 Test failed - status-appveyor |
|
Same failure as last time. Would need to r- ? |
|
@bors r- Why was this even tested a second time. |
bors
added
S-waiting-on-author
|
Not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using the preview image but there doesn't seem to be a reason why, as the commit that originally added it didn't replace the standard image, but just used the preview from the start.
AppVeyor Support recommended switching to the standard image in this support thread.
r? @alexcrichton
fixes #61931