Use early unwraps instead of bubbling up errors just to unwrap in the end #58518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Looks reasonable, and Travis agrees. @bors r+ |
|
📌 Commit 9cdfff62f45cc5d4819060cf252a6a6375be8f0e has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #58691) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
oli-obk
force-pushed
the
unreachable_result_errors
branch
from
9cdfff6 to
5c0615b
Compare
|
@bors r=RalfJung |
|
📌 Commit 5c0615b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…r=RalfJung Use early unwraps instead of bubbling up errors just to unwrap in the end r? @RalfJung
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…r=RalfJung Use early unwraps instead of bubbling up errors just to unwrap in the end r? @RalfJung
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…r=RalfJung Use early unwraps instead of bubbling up errors just to unwrap in the end r? @RalfJung
bors
added a commit
that referenced
this pull request
Mar 9, 2019
Rollup of 13 pull requests Successful merges: - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end) - #58626 (rustdoc: add option to calculate "documentation coverage") - #58629 (rust-lldb: fix crash when printing empty string) - #58660 (MaybeUninit: add read_initialized, add examples) - #58670 (fixes #52482) - #58676 (look for python2 symlinks before bootstrap python) - #58679 (Refactor passes and pass execution to be more parallel) - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const) - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`) - #58924 (Add as_slice() to slice::IterMut and vec::Drain) - #58990 (Actually publish miri in the manifest) - #59018 (std: Delete a by-definition spuriously failing test) - #59045 (Expose new_sub_parser_from_file) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung