Skip to content

Conversation

alexcrichton
Copy link
Member

This commit is an attempt to fix an issue 1 in the latest betas for
MinGW where it appears that libgit2 is no longer functional and always
returns errors. The attempted fix 2 has been published as a new
version of libgit2-sys, so this updates the beta branch to using that
commit to get it out and see if it fixes beta.

This commit is an attempt to fix an issue [1] in the latest betas for
MinGW where it appears that `libgit2` is no longer functional and always
returns errors. The attempted fix [2] has been published as a new
version of `libgit2-sys`, so this updates the beta branch to using that
commit to get it out and see if it fixes beta.

[1]: rust-lang#54206 (comment)
[2]: alexcrichton/git2-rs@9c1604e
@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 21, 2018

📌 Commit 25d35dc has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2018
@alexcrichton
Copy link
Member Author

@bors: p=3

(fixing broken betas for all MinGW users)

@mati865
Copy link
Member

mati865 commented Sep 21, 2018

PR for nightly is missing?
BTW the fix works: https://github.com/alexcrichton/git2-rs/pull/355

@alexcrichton
Copy link
Member Author

Thanks for checking! Nightly is rolled into #54334

@bors
Copy link
Collaborator

bors commented Sep 21, 2018

⌛ Testing commit 25d35dc with merge cb9c85a...

bors added a commit that referenced this pull request Sep 21, 2018
[beta] Update the `libgit2-sys` crate

This commit is an attempt to fix an issue [1] in the latest betas for
MinGW where it appears that `libgit2` is no longer functional and always
returns errors. The attempted fix [2] has been published as a new
version of `libgit2-sys`, so this updates the beta branch to using that
commit to get it out and see if it fixes beta.

[1]: #54206 (comment)
[2]: alexcrichton/git2-rs@9c1604e
@bors
Copy link
Collaborator

bors commented Sep 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing cb9c85a to beta...

@bors bors merged commit 25d35dc into rust-lang:beta Sep 22, 2018
@alexcrichton alexcrichton deleted the beta-next branch September 22, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants