Code

convert NLL ops to caches#51538

Code

Merged

bors merged 72 commits intorust-lang:masterrust-lang/rust:masterfrom

nikomatsakis:nll-perf-examinationnikomatsakis/rust:nll-perf-examinationCopy head branch name to clipboard

Jun 28, 2018

Commits

Commits on Jun 26, 2018

• introduce `type_op`

  nikomatsakis

  committed
  909b10c

  Copy full SHA for 909b10c

• introduce `Subtype` type_op

  nikomatsakis

  committed
  2b52793

  Copy full SHA for 2b52793

• introduce `Eq` type-op

  nikomatsakis

  committed
  9b4fe44

  Copy full SHA for 9b4fe44

• introduce `trivial_noop` to accommodate micro-optimizations

  nikomatsakis

  committed
  7c62461

  Copy full SHA for 7c62461

• introduce `prove_predicates` type op

  nikomatsakis

  committed
  214d765

  Copy full SHA for 214d765

• make `normalize` take ownership of the thing to be normalized

  nikomatsakis

  committed
  8147d17

  Copy full SHA for 8147d17

• let `trivial_noop` take ownership of `self`

  nikomatsakis

  committed
  f998628

  Copy full SHA for f998628

• make normalize into an op

  nikomatsakis

  committed
  846cc26

  Copy full SHA for 846cc26

• create `InfcxTypeOp` that only depend on an `infcx`

  Show description for 13e7793
  nikomatsakis

  committed
  13e7793

  Copy full SHA for 13e7793

• resolve type vars *before* entering `type_must_outlive`

  Show description for 5829746
  nikomatsakis

  committed
  5829746

  Copy full SHA for 5829746

• obligations.rs: rustfmt

  nikomatsakis

  committed
  b858ed5

  Copy full SHA for b858ed5

• make `TypeOutlives` parameterized over a delegate

  Show description for 65ceec7
  nikomatsakis

  committed
  65ceec7

  Copy full SHA for 65ceec7

• extract a `enabled` helper to remove some ad-hoc conditionals

  nikomatsakis

  committed
  e7a9e7a

  Copy full SHA for e7a9e7a

• make `TypeOp` implement debug instead of carrying a closure

  Show description for 7a641cb
  nikomatsakis

  committed
  7a641cb

  Copy full SHA for 7a641cb

• introduce `DropckOutlives` type-op

  nikomatsakis

  committed
  252a6df

  Copy full SHA for 252a6df

• promote `type_op` into a `mod.rs` file

  nikomatsakis

  committed
  dee1886

  Copy full SHA for dee1886

• remove the `TypeOp` vs `InfcxTypeOp` distinction

  nikomatsakis

  committed
  efc84c8

  Copy full SHA for efc84c8

• mk `fully_perform_op_and_get_region_constraint_data` a TypeOp method

  nikomatsakis

  committed
  6ac8917

  Copy full SHA for 6ac8917

• align the `type-op` outputs with what canonicalized queries give

  nikomatsakis

  committed
  7123427

  Copy full SHA for 7123427

• promote canonical into a module

  nikomatsakis

  committed
  5e9f8d5

  Copy full SHA for 5e9f8d5

• break canonicalizer into submodules to make it easier to comprehend

  nikomatsakis

  committed
  a1811ce

  Copy full SHA for a1811ce

• move `make_query_response` into method on infcx

  nikomatsakis

  committed
  dfd33f5

  Copy full SHA for dfd33f5

• extract a helper for `make_query_result` that skips canonicalization

  nikomatsakis

  committed
  bebd3ff

  Copy full SHA for bebd3ff

• extract the handling of region constraints from queries

  nikomatsakis

  committed
  2624c14

  Copy full SHA for 2624c14

• replace `LexicalRegionConstraintData` with `QueryRegionConstraint`

  nikomatsakis

  committed
  c8cf710

  Copy full SHA for c8cf710

• improve `trivial_case` handling

  nikomatsakis

  committed
  7358931

  Copy full SHA for 7358931

• make one `Canonicalize` impl for `QueryResult`

  Show description for be27a5a
  nikomatsakis

  committed
  be27a5a

  Copy full SHA for be27a5a

• move `Debug` bounds onto `Lift`

  Show description for 21592cd
  nikomatsakis

  committed
  21592cd

  Copy full SHA for 21592cd

• change to `crate` privacy instead of `pub(super)`

  nikomatsakis

  committed
  7cb86ed

  Copy full SHA for 7cb86ed

• extract type-ops into their own submodules

  nikomatsakis

  committed
  3f1961d

  Copy full SHA for 3f1961d

• make `convert` so it can apply to a single constraint

  nikomatsakis

  committed
  e72dc79

  Copy full SHA for e72dc79

• rename `instantiate_query_result`

  nikomatsakis

  committed
  75e3a9c

  Copy full SHA for 75e3a9c

• extract `query_result_substitution` helper

  nikomatsakis

  committed
  d748dc5

  Copy full SHA for d748dc5

• remove `Canonicalization` trait, which serves no purpose

  nikomatsakis

  committed
  1d66462

  Copy full SHA for 1d66462

• introduce `QueryTypeOp` trait and use it for `eq`

  nikomatsakis

  committed
  3b446b4

  Copy full SHA for 3b446b4

• move `type_op` into `rustc`

  nikomatsakis

  committed
  2655522

  Copy full SHA for 2655522

• introduce `canonicalize_hr_query_hack`

  Show description for 1acffad
  nikomatsakis

  committed
  1acffad

  Copy full SHA for 1acffad

• make `Eq` a true query

  nikomatsakis

  committed
  71ce2e7

  Copy full SHA for 71ce2e7

• make `Subtype` a true query

  nikomatsakis

  committed
  4beea99

  Copy full SHA for 4beea99

• convert `predicates` to operate on 1 predicate at a time

  nikomatsakis

  committed
  d613683

  Copy full SHA for d613683

• convert `prove_predicate` into a query

  nikomatsakis

  committed
  de7e941

  Copy full SHA for de7e941

• introduce `Normalizable` trait for things directly normalizable

  nikomatsakis

  committed
  2a0b3d6

  Copy full SHA for 2a0b3d6

• transition to `Fallible`

  nikomatsakis

  committed
  3e32d42

  Copy full SHA for 3e32d42

• instantiate closure requirements as query-region-constraints [WIP]

  Show description for 7c72e77
  nikomatsakis

  committed
  7c72e77

  Copy full SHA for 7c72e77

• WIP fix error messages for propagate_approximated_shorter_to_static_no_bound

  nikomatsakis

  committed
  7bab9f0

  Copy full SHA for 7bab9f0

• extract more helpers from instantiating query result

  nikomatsakis

  committed
  f24e90e

  Copy full SHA for f24e90e

• introduce `QueryKey` separation

  nikomatsakis

  committed
  977f3fc

  Copy full SHA for 977f3fc

• convert `dropck_outlives` type-op to use the query

  nikomatsakis

  committed
  e895f3a

  Copy full SHA for e895f3a

• add a streamlined `instantiate_query_result` method for NLL queries

  nikomatsakis

  committed
  a583269

  Copy full SHA for a583269

• convert query-type-op to create query-region-constraint directly

  nikomatsakis

  committed
  82169b6

  Copy full SHA for 82169b6

• do not re-create the `LocationTable` for every path

  Show description for e98d376
  nikomatsakis

  committed
  e98d376

  Copy full SHA for e98d376

Commits on Jun 27, 2018

• nit: don't import Debug directly

  nikomatsakis

  committed
  188ad38

  Copy full SHA for 188ad38

• extract out query boilerplate and use for `Eq`

  nikomatsakis

  committed
  2fd8a31

  Copy full SHA for 2fd8a31

• use query boilerplate for `normalize`

  nikomatsakis

  committed
  fa71af4

  Copy full SHA for fa71af4

• use query boilerplate for subtype

  nikomatsakis

  committed
  ac40d73

  Copy full SHA for ac40d73

• use query boilerplate for prove-predicate -- slightly inefficient

  Show description for e6c8c63
  nikomatsakis

  committed
  e6c8c63

  Copy full SHA for e6c8c63

• use query boiler plate for `normalize_projection_ty` too

  nikomatsakis

  committed
  66c8839

  Copy full SHA for 66c8839

• merge all the `type_op_foo` modules into one as they are so trivial

  nikomatsakis

  committed
  d49d522

  Copy full SHA for d49d522

• fix wrong query description

  nikomatsakis

  committed
  d695512

  Copy full SHA for d695512

• rename `upcast` to `cast_to_tcx_lifetime` and improve comment

  nikomatsakis

  committed
  59ea17e

  Copy full SHA for 59ea17e

• remove `either` dependency we are not using

  nikomatsakis

  committed
  5bfdb97

  Copy full SHA for 5bfdb97

• improve comment on instantiate NLL query result fn

  nikomatsakis

  committed
  1be4fff

  Copy full SHA for 1be4fff

• improve comments on `dropck_outlives`

  nikomatsakis

  committed
  c6a7c6f

  Copy full SHA for c6a7c6f

• pacify the mercilous tidy

  nikomatsakis

  committed
  35a5065

  Copy full SHA for 35a5065

• extend comment to note complications around lifetimes

  nikomatsakis

  committed
  c2f7757

  Copy full SHA for c2f7757

• rename to `shrink_to_tcx_lifetime`

  nikomatsakis

  committed
  c3f7e02

  Copy full SHA for c3f7e02

• move into `provide` methods

  nikomatsakis

  committed
  b2e899f

  Copy full SHA for b2e899f

• pull out `ParamEnvAnd` and remove `QueryKey`

  nikomatsakis

  committed
  0a0dae0

  Copy full SHA for 0a0dae0

• rename `prequery` to `try_fast_path`

  nikomatsakis

  committed
  5fd3b26

  Copy full SHA for 5fd3b26

• update comments

  nikomatsakis

  committed
  f0fdce3

  Copy full SHA for f0fdce3

• change the `enter_canonical_trait_query` method to give a fulfill cx

  nikomatsakis

  committed
  9b1d222

  Copy full SHA for 9b1d222

• rustfmt various files

  nikomatsakis

  committed
  1523de3

  Copy full SHA for 1523de3