Reword reason for move note #47124
Merged
Reword reason for move note #47124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
estebank
force-pushed
the
loan-paths
branch
10 times, most recently
from
503bdc3 to
65ac7e8
Compare
estebank
force-pushed
the
loan-paths
branch
2 times, most recently
from
89c1e15 to
ce930bb
Compare
nikomatsakis
reviewed
Jan 3, 2018
| @@ -346,6 +346,16 @@ impl<'tcx> LoanPath<'tcx> { | |||
| } | |||
|
|
|||
| fn to_type(&self) -> Ty<'tcx> { self.ty } | |||
|
|
|||
| fn is_downcast(&self) -> bool { | |||
There was a problem hiding this comment.
Nit: maybe call this has_downcast? Also, we should try this out with the MIR borrowck.
nikomatsakis
approved these changes
Jan 3, 2018
|
@bors r=nikomatsakis |
|
📌 Commit a4d46b3 has been approved by |
estebank
added
S-waiting-on-bors
|
⌛ Testing commit a4d46b3 with merge 681c86ad0f7ce4158656a312031b47151ff87c24... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 4, 2018
Reword reason for move note On move errors, when encountering an enum variant, be more ambiguous and do not refer to the type on the cause note, to avoid referring to `(maybe as std::prelude::v1::Some).0`, and instead refer to `the value`. Sidesteps part of the problem with #41962: ``` error[E0382]: use of partially moved value: `maybe` --> file.rs:5:30 | 5 | if let Some(thing) = maybe { | ----- ^^^^^ value used here after move | | | value moved here = note: move occurs because the value has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait error[E0382]: use of moved value: `(maybe as std::prelude::v1::Some).0` --> file.rs:5:21 | 5 | if let Some(thing) = maybe { | ^^^^^ value moved here in previous iteration of loop = note: move occurs because the value has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait error: aborting due to 2 previous errors ``` Previous discussion: #44360 r? @arielb1
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On move errors, when encountering an enum variant, be more ambiguous and do not refer to the type on the cause note, to avoid referring to
(maybe as std::prelude::v1::Some).0, and instead refer tothe value.Sidesteps part of the problem with #41962:
Previous discussion: #44360
r? @arielb1