Fixes #29946 (missing drop in FnOnce adapter for closures) #31462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
thepowersgang
force-pushed
the
fix_29946
branch
from
c01f6d0 to
6940ae5
Compare
|
r? @pnkfelix |
thepowersgang
force-pushed
the
fix_29946
branch
from
6940ae5 to
f08626b
Compare
pnkfelix
changed the title
|
@bors r+ |
|
📌 Commit f08626b has been approved by |
|
⌛ Testing commit f08626b with merge 0ce3399... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
Just for your information, after running tests with leak sanitizer I noticed |
|
@tmiasko Nice to see it's fixed more than just the original reporter's issue :) The explicit test in this PR explicitly checks for this case, so it shouldn't pop up again. Re the failed test, it looks like the test runner timed out during the net tests. Not sure if this is a known transient failure or not. |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 8, 2016
Generates drop calls at the end of the Fn/FnMut -> FnOnce closure shim Fix #29946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates drop calls at the end of the Fn/FnMut -> FnOnce closure shim
Fix #29946