Rollup of 12 pull requests #24798
Merged
Rollup of 12 pull requests #24798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Apr 25, 2015
steveklabnik
commented
- Successful merges: Add examples to fmt precision #24662, TRPL: deref coercions #24722, TRPL: operators and overloading #24725, Remove the grammar from the reference #24729, TRPL: mutability #24736, Add feature gate tests #24749, Remove duplicate feature gate tests #24751, Byte string literals are now fixed-size arrays #24766, Reference manual 3.5.2.1.5 #24769, Remove reference to 'to' #24772, Reference: Update 7.2.20 (for loops) and fix formatting #24775, rustbook: Fixes display of navigation links in README.html. #24790
- Failed merges: More small syntax changes in reference.md #24760
table, introduce a `FreeRegionMap` data structure. regionck computes the `FreeRegionMap` for each fn and stores the result into the tcx so that borrowck can use it (this could perhaps be refactored to have borrowck recompute the map, but it's a bid tedious to recompute due to the interaction of closures and free fns). The main reason to do this is because of rust-lang#22779 -- using a global table was incorrect because when validating impl method signatures, we want to use the free region relationships from the *trait*, not the impl. Fixes rust-lang#22779.
As part of the audit for rust-lang#22820 the following feature gate tests have been added: * `negate_unsigned` * `on_unimplemented` * `optin_builtin_traits` * `plugin` * `rustc_attrs` * `slice_patterns`
As part of the audit for rust-lang#22820 the following feature gate tests have been added: * `rustc_diagnostic_macros` /cc rust-lang#19624
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively.
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
`is` and `us` suffixes are deprecated in favor of `isize` and `usize`.
- Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
Audit & Edit Chapter 8.1 Types in reference manual - Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
* `for` loops now use `IntoIterator` instead of just `Iterator` * Simplify the example by removing unnecessary `Vec::iter` call.
why use dummy implementation on linux?
…ned-impl, r=pnkfelix Rather than storing the relations between free-regions in a global table, introduce a `FreeRegionMap` data structure. regionck computes the `FreeRegionMap` for each fn and stores the result into the tcx so that borrowck can use it (this could perhaps be refactored to have borrowck recompute the map, but it's a bid tedious to recompute due to the interaction of closures and free fns). The main reason to do this is because of rust-lang#22779 -- using a global table was incorrect because when validating impl method signatures, we want to use the free region relationships from the *trait*, not the impl. Fixes rust-lang#22779.
I forgot these heavily use associated types, so move it after that as well.
Fixes rust-lang#24656 r? @pnkfelix I just added the examples, but if the wording needs expanded too, let me know what you think should be added :)
…loading, r=alexcrichton I forgot these heavily use associated types, so move it after that as well.
…labnik From rust-lang#24723 (comment) : > Yes, I've been meaning to just remove it in favor of GRAMMAR.md > - steveklabnik
…crichton Okay, last chapter other than ownership stuff. 🎊
As part of the audit for rust-lang#22820 the following feature gate tests have been added: * `negate_unsigned` * `on_unimplemented` * `optin_builtin_traits` * `plugin` * `rustc_attrs` * `rustc_diagnostic_macros` * `slice_patterns` In addition some feature gate error message typos fixed.
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
`is` and `us` suffixes are deprecated in favor of `isize` and `usize`.
Update 7.2.20 (`for` expressions): * `for` loops now use `IntoIterator` instead of just `Iterator` * Simplify the example by removing unnecessary `Vec::iter` call. ...and a fix for a minor formatting error. r? @steveklabnik
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=100 |
|
📌 Commit 23b1d17 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.