Skip to content

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Aug 17, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPV and others added 30 commits May 29, 2025 22:10
this fixes `tests/ui/process/nofile-limit.rs` which fails to link on
nixos for me without this change
The target is removed by `copy_link` too, so no need to duplicate the syscall.
Fix typo in doc for library/std/src/fs.rs#set_permissions

"privalage" -> "privilege".

Was reading the docs and have noticed this.
…rgets, r=jdonszelmann

Fix deprecation attributes on foreign statics

r? ```````@jdonszelmann```````

Fixes rust-lang#145437
Fix `unicode_data.rs` mention message

The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.
…p, r=jdonszelmann

remove `should_render` in `PrintAttribute` derive

It just seems to be always `true`, so don't do extra work emitting extra logic just for a `true`.

cc ``@jdonszelmann``
…chenkov

Simplify span caches

Split from rust-lang#143882

r? ``@petrochenkov``
…riplett

Rust build fails on OpenBSD after using file_lock feature

PR 130999 added the file_lock feature, but doesn't included OpenBSD in the supported targets (Tier 3 platform), leading to a compilation error ("try_lock() not supported").

Cc `@cberner`

Related to rust-lang#130999
Reorder `lto` options from most to least optimizing

This is a follow up to rust-lang/cargo#15841.

`@weihanglo` pointed out the original order of the `lto` options in the Cargo book was consistent with https://doc.rust-lang.org/rustc/codegen-options/index.html?highlight=lto#lto.

The options in the Cargo book have since been reordered. This PR keeps the two references consistent.
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Aug 17, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Aug 17, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Aug 17, 2025

📌 Commit b8e8c24 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2025
@Zalathar
Copy link
Contributor

Looks like the retry of #145526 and creation of this rollup happened at the same time.

Given that #145526 is very likely to succeed (since it only failed on one job flaking out) and contains two rollup=iffy PRs, are you fine with closing this rollup?

@jhpratt
Copy link
Member Author

jhpratt commented Aug 18, 2025

@Zalathar Do whatever you'd like. I was mostly happy that bors worked long enough to create the rollup 😅

@Zalathar Zalathar closed this Aug 18, 2025
@jhpratt jhpratt deleted the rollup-jbmt70w branch August 18, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.