ci: clean windows disk space in background #145311
Merged
+184
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 12, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
|
💔 Test for 8cf61b6 failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
d3be181 to
2290350
Compare
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
2290350 to
2434d72
Compare
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
2434d72 to
ee2962a
Compare
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 13, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
|
Now cleaning the disk space takes 0 seconds. Nice. |
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
ee2962a to
2c2dcda
Compare
marcoieni
commented
Aug 14, 2025
| @@ -223,6 +223,11 @@ jobs: | |||
| cd src/ci/citool | |||
| CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=../../../build/citool cargo build | |||
|
|
|||
| - name: wait for Windows disk cleanup to finish | |||
| if: ${{ matrix.free_disk && startsWith(matrix.os, 'windows-') }} | |||
There was a problem hiding this comment.
later, if we want to do the same for linux, we can remove startsWith(matrix.os, 'windows-')
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
6 times, most recently
from
8b30259 to
addc8ba
Compare
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 14, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
addc8ba to
75b7d24
Compare
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 14, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Aug 15, 2025
Rollup of 11 pull requests Successful merges: - #144210 (std: thread: Return error if setting thread stack size fails) - #145310 (Reduce usage of `compiler_for` in bootstrap) - #145311 (ci: clean windows disk space in background) - #145340 (Split codegen backend check step into two and don't run it with `x check compiler`) - #145408 (Deduplicate -L search paths) - #145412 (Windows: Replace `GetThreadId`+`GetCurrentThread` with `GetCurrentThreadId`) - #145413 (bootstrap: Reduce dependencies) - #145426 (Fix typos in bootstrap.example.toml) - #145430 (Fix wrong spans with external macros in the `dropping_copy_types` lint) - #145431 (Enhance UI test output handling for runtime errors) - #145448 (Autolabel `src/tools/{rustfmt,rust-analyzer}` changes with `T-{rustfmt,rust-analyzer}`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 15, 2025
Rollup merge of #145311 - marcoieni:clean-disk-in-background-windows, r=Kobzol ci: clean windows disk space in background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up cleaning up disk space by launching the process in the background.
We wait for it to finish before running the build.
The con of this PR is that it adds extra complexity. However, cleaning up disk space on windows can take a lot of time (in the latest auto build I saw one job taking 8 minutes for example).
Context
The disk space cleanup was introduced in #144305
Test
I tested that the waiting mechanism works in https://github.com/marcoieni/actions-test/actions/runs/16935555049/job/47991148801:
Overall speed
I compared the duration of the jobs of the try build with the latest auto build and I noticed a speed up in most of the jobs. Some jobs are slower but that's probably because of unrelated CI reasons.