Port #[non_exhaustive] to the new attribute parsing infrastructure
#143085
+106
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Brouwer <[email protected]>
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures |
JonathanBrouwer
commented
Jun 27, 2025
| @@ -2746,7 +2746,8 @@ fn add_without_unwanted_attributes<'hir>( | |||
| attrs.push((Cow::Owned(attr), import_parent)); | |||
| } | |||
| } | |||
| hir::Attribute::Parsed(..) if is_inline => { | |||
| // FIXME: make sure to exclude `#[cfg_trace]` here when it is ported to the new parsers | |||
| hir::Attribute::Parsed(..) => { | |||
There was a problem hiding this comment.
This PR is blocked on #143083, because it needs it to get a passing CI.
This PR contains that PR as a commit. Other than that, this should be reviewable.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
9e04a8b to
419f4e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
non_exhaustiveto the new attribute parsing infrastructure for #131229 (comment)r? @jdonszelmann