Clippy subtree update #143064
Open
Clippy subtree update #143064
+3,174
−850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix false positives on broken link detection Refactor variable names Fix doc comment about broken link lint Refactor, remove not used variable Improve broken link to catch more cases and span point to whole link Include reason why a link is considered broken Drop some checker because rustdoc already warn about them Refactor to use a single enum instead of multiple bool variables Fix lint warnings Rename function to collect broken links Warn directly instead of collecting all entries first Iterate directly rather than collecting Temporary change to confirm with code reviewer the next steps Handle broken links as part of the fake_broken_link_callback handler Simplify broken link detection without state machine usage Fix typos Add url check to reduce false positives Drop reason enum as there is only one reason Fix duplicated diagnostics Fix linter
For example, adding `*` in front of `*expression` is best shown as `**expression` rather than `*(*expression)`. This is not perfect, as it checks whether the operator is already a prefix of the expression, but it is better than it was before. For example, `&`+`&mut x` will get `&&mut x` but `&mut `+`&x` will get `&mut (&x)` as it did before this change.
If a reborrow is itself borrowed mutably, do not propose to replace it by the original reference.
…nishearth Clippy subtree update r? `@Manishearth` 1 day late. Got distracted yesterday evening and forgot about it.
…g#14906) Closes rust-lang/rust-clippy#14799 changelog: [`collapsible_else_if`] fix FP on conditionally compiled stmt
|
Thanks for the patch! Feel free to push that to the sync right away. You should have all the necessary permissions. |
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
flip1995
removed
the
T-bootstrap
This makes the intent clear, and silences Clippy.
flip1995
force-pushed
the
clippy-subtree-update
branch
from
a4066a0 to
4b3f31d
Compare
rustbot
added
the
T-bootstrap
This comment was marked as resolved.
This comment was marked as resolved.
flip1995
removed
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
rustbot
added
T-bootstrap
|
Some changes occurred in compiler/rustc_codegen_gcc |
flip1995
removed
T-compiler
This comment has been minimized.
This comment has been minimized.
flip1995
force-pushed
the
clippy-subtree-update
branch
from
06de8a7 to
d9a4fd5
Compare
rustbot
added
T-bootstrap
flip1995
removed
T-compiler
|
Finally CI passed 🎉 |
|
Well done! @bors r+ p=1 |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Cargo.lock update due to version bump