Port #[may_dangle] to the new attribute system
#142539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
| @@ -1302,6 +1302,7 @@ impl AttributeExt for Attribute { | |||
| // FIXME: should not be needed anymore when all attrs are parsed | |||
| Attribute::Parsed(AttributeKind::Deprecation { span, .. }) => *span, | |||
| Attribute::Parsed(AttributeKind::DocComment { span, .. }) => *span, | |||
| Attribute::Parsed(AttributeKind::MayDangle(span)) => *span, | |||
There was a problem hiding this comment.
same feedback as on the other PR. This list should be kept as small as possible and was only introduced for migration purposes. I expect this entire function to be removed.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-blocked
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
f2ffea0 to
d4006e4
Compare
rustbot
added
S-waiting-on-review
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
d4006e4 to
76dfb1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #142498.
This is a part of #131229, so
r? @jdonszelmann