Cache all crates for citool #142395
Closed
Cache all crates for citool #142395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Kobzol
force-pushed
the
citool-more-cache
branch
5 times, most recently
from
f6b1558 to
d49e8ad
Compare
rustbot
added
A-testsuite
Kobzol
force-pushed
the
citool-more-cache
branch
from
d49e8ad to
b5f6cc9
Compare
Even the local workspace ones, since they almost never change.
Kobzol
force-pushed
the
citool-more-cache
branch
from
b5f6cc9 to
c279dda
Compare
|
Okay, no, it seems like rustc-cache fundamentally cannot cache local crates. Also, it looks like without tests, the caching itself is pretty much useless and it takes ~the same time as building things from scratch 🤦♂️ Well, let's keep things as they are then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even the local workspace ones, since they almost never change.
Also remove the manual
CARGO_INCREMENTAL=0setting, it is set automatically byrust-cache.r? @marcoieni