Rollup of 7 pull requests #140895

matthiaskrgr · 2025-05-10T14:26:05Z

Successful merges:

Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] #129334 (Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock])
rustdoc: add a handle that makes sidebar resizing more obvious #139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
remove intrinsics::drop_in_place #140151 (remove intrinsics::drop_in_place)
remove 'unordered' atomic intrinsics #140660 (remove 'unordered' atomic intrinsics)
Update documentation of OnceLock::get_or_init. #140783 (Update documentation of OnceLock::get_or_init.)
Update hermit-abi to 0.5.1 #140789 (Update hermit-abi to 0.5.1)
1.87.0 release notes: remove nonsensical ~ operator #140879 (1.87.0 release notes: remove nonsensical ~ operator)

r? @ghost
@rustbot modify labels: rollup

…force_mut()`

Explicitly point out that if the function panics the init function might be called multiple times.

This change is based on some discussion on [lolbinarycat's idea], but with a more "traditional" design. Specifically, this is the closest thing I could find to a consensus across many systems I looked at for inspiration: - In Jira, resizable sidebars have a stack of four dots. - In The GIMP, resizable sidebars have a stack of three dots. - In [old Windows], "panes" are defined to have the same border style as a window, which has a raised appearance. - In [NeXT], a drag point usually had an innie, whether the line in a slider or the circle in a scroller; I can also hide and show the favorites bar in Workspace by dragging on a circular "grip spot" - In [old Mac], drag handles for things usually had a "grip track" of parallel lines. - [OSX] kept that, but the "Source List" part of the Finder still had the circle grip for a time the same way Workspace did [lolbinarycat's idea]: rust-lang#139420 [old Windows]: https://archive.org/details/windowsinterface00micr/page/n9/mode/2up [old Mac]: https://archive.org/details/apple-hig/1996_Human_Interface_Guidelines_for_Mac_OS_8_%28WWDC_Release%29/page/16/mode/2up [NeXT]: https://archive.org/details/apple-hig/1993%20NeXTSTEP%20User%20Interface%20Guidelines%20-%20Release%203/page/145/mode/2up [OSX]: https://dn721903.ca.archive.org/0/items/apple-hig/MacOSX_HIG_2005_09_08.pdf#page=267

There is no `~` unary prefix operator, and it definitely shouldn't be in the release notes for a feature whose introducing PR doesn't test for it (because it doesn't exist).

… r=Amanieu Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` `DerefMut` is instantly stable, as a trait impl. That means this needs an FCP. ``@rustbot`` label +needs-fcp rust-lang/libs-team#429

…uillaumeGomez rustdoc: add a handle that makes sidebar resizing more obvious This aims to make the resizable sidebars more obvious Preview: <https://notriddle.com/rustdoc-html-demo-12/sidebar-resize-handle/std/index.html> ![image](https://github.com/user-attachments/assets/d4d70982-8045-4fed-818a-982108b0d3b3) ![image](https://github.com/user-attachments/assets/4aaa3663-19f3-4e04-89c6-53db0ddb72ed) ![image](https://github.com/user-attachments/assets/3f612c5b-6be1-4383-801a-067c87425eb9) This change is based on some discussion on [lolbinarycat's idea], but with a more "traditional" design. Specifically, while very few systems use exactly this design, most of them use [a skeumorph](https://ux.stackexchange.com/questions/80463/what-do-the-3-close-horizontal-bars-not-hamburger-menu-represent-and-what-is-t/80591#80591) of a grip texture: - This design is similar to the one used in the Rust Playground, and almost identical to UX StackExchange: <details><img src="https://github.com/user-attachments/assets/39a6bb69-4895-4fd0-87da-b87913bc7309"></details> <details><img src="https://github.com/user-attachments/assets/a41942e1-651b-410b-b855-2aafe8fe54f4"></details> - In Jira, resizable sidebars have a stack of four dots, but only in one row. <details><img src="https://github.com/user-attachments/assets/13047998-02bf-47e6-b796-16f393f870b0"></details> - In The GIMP, resizable sidebars have a stack of three dots. <details><img src="https://github.com/user-attachments/assets/138f5c21-3069-4bbe-b306-0bb9a4bf0318"></details> - In [old Windows], "panes" are defined to have the same border style as a window, which has a raised appearance. To evoke this, the PR adds a lightweight "shadow" border, darker than the sidebar itself <details><img src="https://github.com/user-attachments/assets/301da4b8-6c48-4131-b741-1689af84670a"></details> - In [NeXT], a drag point usually had an innie, whether the line in a slider or the circle in a scroller; I can also hide and show the favorites bar in Workspace by dragging on a circular "grip spot" <details><img src="https://github.com/user-attachments/assets/b13c2d30-a3a8-4672-90fa-58c1fdf19f42"></details> - In [old Mac], drag handles for things usually had a "grip track" of parallel lines. <details><img src="https://github.com/user-attachments/assets/1fbecc67-ffbc-4ed6-a8c5-a9ff085638db"></details> *This design is far closer to old Mac than anything else*, though they've put it in the bottom corner instead of the middle. - [OSX] kept that, but the "Source List" part of the Finder still had the circle grip for a time the same way Workspace did (resulting in an odd mishmash, if you compare the source list sidebar with the other grip tracks embedded in the scrollbars). <details><img src="https://github.com/user-attachments/assets/551b8f9d-2dd8-4291-917f-dc88741a2b97"></details> [lolbinarycat's idea]: rust-lang#139420 [old Windows]: https://archive.org/details/windowsinterface00micr/page/n9/mode/2up [old Mac]: https://archive.org/details/apple-hig/1996_Human_Interface_Guidelines_for_Mac_OS_8_%28WWDC_Release%29/page/16/mode/2up [NeXT]: https://archive.org/details/apple-hig/1993%20NeXTSTEP%20User%20Interface%20Guidelines%20-%20Release%203/page/145/mode/2up [OSX]: https://dn721903.ca.archive.org/0/items/apple-hig/MacOSX_HIG_2005_09_08.pdf#page=267

…ntrinsic, r=Mark-Simulacrum remove intrinsics::drop_in_place This was only ever accidentally stable, and has been marked as deprecated since Rust 1.52, released almost 4 years ago. We've removed the old serialization `derive`s, maybe we can remove this one as well? As suggested by ``@jhpratt,`` let's see what crater says for this one.

remove 'unordered' atomic intrinsics As their doc comment already indicates, these operations do not currently have a place in our memory model. The intrinsics were introduced to support a hack in compiler-builtins, but that hack recently got removed (see rust-lang/compiler-builtins#788).

Update documentation of OnceLock::get_or_init. Explicitly point out that if the function panics the init function might be called multiple times.

…-Simulacrum Update hermit-abi to 0.5.1 This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.

…bini 1.87.0 release notes: remove nonsensical `~` operator There is no `~` unary prefix operator, and it definitely shouldn't be in the release notes for a feature whose introducing PR doesn't test for it (because it doesn't exist). Also fix an unnecessary `}` on the same line. r? ``@pietroalbini``

matthiaskrgr · 2025-05-10T14:26:20Z

@bors r+ rollup=never p=5

bors · 2025-05-10T14:26:23Z

📌 Commit 3ca41e2 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-05-10T17:29:46Z

⌛ Testing commit 3ca41e2 with merge dbab4e1...

bors · 2025-05-10T20:40:11Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing dbab4e1 to master...

rust-timer · 2025-05-10T20:42:11Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129334	Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/L…	`fc602444eb905e671b62f42962ca509959d195cd` (link)
#139562	rustdoc: add a handle that makes sidebar resizing more obvi…	`efdb865009c410863411988d031d687512388923` (link)
#140151	remove intrinsics::drop_in_place	`27c2663e33d98b46f11635f7ce9633855fd142ef` (link)
#140660	remove 'unordered' atomic intrinsics	`f791102315372538e86277efc4abc11b0c2c8e1f` (link)
#140783	Update documentation of OnceLock::get_or_init.	`c898d12c7f56be90e48459b19f3eea702d40d8b4` (link)
#140789	Update hermit-abi to 0.5.1	`a1839f7ad73a3e148b17eacef7b1c9c23af164e7` (link)
#140879	1.87.0 release notes: remove nonsensical `~` operator	`1cbd95cfecca70ee618473ade4067d3f6beabf17` (link)

previous master: b10555674f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-05-10T20:43:10Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b105556 (parent) -> dbab4e1 (this PR)

Test differences

Show 96 test diffs

96 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard dbab4e152bd9eed57ccfc096ef6060dd9af45a99 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 6423.6s -> 7194.4s (12.0%)
i686-gnu-1: 8420.4s -> 9080.8s (7.8%)
dist-arm-linux: 4587.6s -> 4939.4s (7.7%)
x86_64-gnu-debug: 6478.0s -> 6021.7s (-7.0%)
x86_64-apple-2: 4659.4s -> 4360.5s (-6.4%)
dist-aarch64-linux: 5634.6s -> 5288.2s (-6.1%)
dist-android: 2611.3s -> 2461.4s (-5.7%)
dist-x86_64-netbsd: 5184.9s -> 4922.0s (-5.1%)
x86_64-mingw-2: 6827.9s -> 7144.9s (4.6%)
dist-aarch64-apple: 5327.0s -> 5567.4s (4.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-10T22:10:35Z

Finished benchmarking commit (dbab4e1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.3%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.7%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-1.7%, 1.3%]	7

Cycles

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.4%, 0.6%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.555s -> 772.568s (0.00%)
Artifact size: 365.35 MiB -> 365.47 MiB (0.03%)

ChayimFriedman2 and others added 17 commits November 16, 2024 22:23

Add DerefMut for Lazy[Cell/Lock] that delegates to the unstable `…

b208706

…force_mut()`

remove intrinsics::drop_in_place

e7efab9

update hermit-abi to 0.5.1

ca42f15

Update documentation of OnceLock::get_or_init.

ae25c39

Explicitly point out that if the function panics the init function might be called multiple times.

remove 'unordered' atomic intrinsics

79dfd0a

rustdoc: add tooltip to resize track

3c9e1f9

rustdoc: use a different style of grip track

e6e5206

RELEASES.md: fix nonsensical ~ operator

10980be

There is no `~` unary prefix operator, and it definitely shouldn't be in the release notes for a feature whose introducing PR doesn't test for it (because it doesn't exist).

RELEASES.md: fix unbalanced and unneeded }

2c5f64d

Rollup merge of rust-lang#129334 - ChayimFriedman2:more-lazy-methods,…

c6b9253

… r=Amanieu Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` `DerefMut` is instantly stable, as a trait impl. That means this needs an FCP. ``@rustbot`` label +needs-fcp rust-lang/libs-team#429

Rollup merge of rust-lang#140783 - veluca93:oncelock-docs, r=jhpratt

8186b71

Update documentation of OnceLock::get_or_init. Explicitly point out that if the function panics the init function might be called multiple times.

Rollup merge of rust-lang#140789 - hermit-os:hermit-abi-0.5.1, r=Mark…

86fb03e

…-Simulacrum Update hermit-abi to 0.5.1 This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025

bors mentioned this pull request May 10, 2025

[beta-1.88] Update cargo #140897

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2025

bors merged commit dbab4e1 into rust-lang:master May 10, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #140895

Rollup of 7 pull requests #140895

Uh oh!

matthiaskrgr commented May 10, 2025

Uh oh!

matthiaskrgr commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

Uh oh!

rust-timer commented May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

rust-timer commented May 10, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #140895

Rollup of 7 pull requests #140895

Uh oh!

Conversation

matthiaskrgr commented May 10, 2025

Uh oh!

matthiaskrgr commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

bors commented May 10, 2025

Uh oh!

Uh oh!

rust-timer commented May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented May 10, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!