Reduce special casing for the panic runtime #140809
Open
+64
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa |
|
I was looking at making panic_abort and panic_unwind depend on libstd (#139103 (comment)). These changes make this easier, though is still blocked on the fact that when compiling libstd as dylib, panic_unwind already needs to be present. |
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
6d4613c to
c7e8663
Compare
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
c7e8663 to
93cf365
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
93cf365 to
a9d5498
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
d730005 to
7d0f158
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
7d0f158 to
0dfacc7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
0dfacc7 to
6df5456
Compare
|
r? wesleywiser |
wesleywiser
approved these changes
Jun 6, 2025
|
Compiler changes look good to me but I'd like someone from libs to review the change in exposed standard library features to make sure there's no concerns there. r? libs |
|
Looks fine to me. @bors r=wesleywiser,ibraheemdev |
bors
removed
the
S-waiting-on-review
This used to be necessary for a correct linker order, but ever since the introduction of symbols.o adding the symbols in question to symbols.o would work just as well. We do still add dependencies on the panic runtime to the local crate, but not for #![needs_panic_runtime] crates. This also removes the runtime-depends-on-needs-runtime test. inject_dependency_if used to emit this error, but with symbols.o it is no longer important that there is no dependency and in fact it may be nice to have panic_abort and panic_unwind directly depend on libstd in the future for calling std::process::abort().
You shouldn't ever need to explicitly depend on it. And we weren't checking that the panic runtime used the correct panic strategy either.
There is already panic-unwind to enable it.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
0819538 to
f5af05b
Compare
|
r? wesleywiser, the new commits are not libs related. |
|
|
|
r? compiler |
|
r? compiler |
petrochenkov
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks! |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 27, 2025
…trochenkov Reduce special casing for the panic runtime See the individual commits for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more info.