Skip to content

Add an aarch64-msvc build running on ARM64 Windows #140136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Add an aarch64-msvc build running on ARM64 Windows #140136

merged 1 commit into from
Jul 11, 2025

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Apr 21, 2025 •
edited by rustbot
Loading

Resurrecting #126341

Per rust-lang/rfcs#3817 we intend to promote aarch64-pc-windows-msvc to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the dist-aarch64-msvc job will also be run on Arm64 Windows runners.

r? @Kobzol

try-job: *aarch64-msvc*

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 23, 2025

☔ The latest upstream changes (presumably #138591) made this pull request unmergeable. Please resolve the merge conflicts.

@dpaoliello dpaoliello force-pushed the arm64winci branch 2 times, most recently from b26ede0 to 6677d07 Compare April 23, 2025 17:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dpaoliello dpaoliello closed this Apr 23, 2025
@dpaoliello dpaoliello reopened this Apr 24, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the PG-exploit-mitigations Project group: Exploit mitigations label Apr 25, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dpaoliello dpaoliello force-pushed the arm64winci branch 2 times, most recently from d729d12 to 4f5a07f Compare April 28, 2025 19:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 2953787 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 22, 2025
@jhpratt
Rollup merge of rust-lang#140136 - dpaoliello:arm64winci, r=Kobzol
06c4f56 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
@jhpratt jhpratt mentioned this pull request Jun 22, 2025
Closed
bors added a commit that referenced this pull request Jun 23, 2025
@bors
Auto merge of #142895 - jhpratt:rollup-bepls8m, r=jhpratt
8dcae0e 
Rollup of 6 pull requests

Successful merges:

 - #140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - #141597 (Document subdirectories of UI tests with README files)
 - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure)
 - #142828 (1.88.0 release notes)
 - #142854 (centralize `-Zmin-function-alignment` logic)
 - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#142895 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@dpaoliello
Copy link
Contributor Author

#142895 (comment)

After a week of debugging, I've narrowed this down to an issue in LLVM: llvm/llvm-project#146973

@dpaoliello
Copy link
Contributor Author

#142895 (comment)

After a week of debugging, I've narrowed this down to an issue in LLVM: llvm/llvm-project#146973

PR to fix the issue in LLVM: llvm/llvm-project#147421

@dianqk dianqk mentioned this pull request Jul 10, 2025
Merged
@dpaoliello
Copy link
Contributor Author

@rustbot ready
@Kobzol Test failure has been fixed, I think this is ready to land again.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2025
@Kobzol
Copy link
Member

Kobzol commented Jul 10, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 10, 2025

📌 Commit 2953787 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 10, 2025
@tgross35
Rollup merge of rust-lang#140136 - dpaoliello:arm64winci, r=Kobzol
a37b01d 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
@tgross35 tgross35 mentioned this pull request Jul 10, 2025
Closed
bors added a commit that referenced this pull request Jul 10, 2025
@bors
Auto merge of #143755 - tgross35:rollup-clvq7yu, r=tgross35
7f01dc1 
Rollup of 8 pull requests

Successful merges:

 - #140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - #143642 (stdarch subtree update)
 - #143679 (Preserve the .debug_gdb_scripts section)
 - #143707 (Fix `--skip-std-check-if-no-download-rustc`)
 - #143722 (Make some "safe" llvm ops actually sound)
 - #143728 (Resolve refactor: extraction of `finalize_module_binding` and `single_import_can_define_name`)
 - #143742 (Rework borrowing suggestions to use `Expr` instead of just `Span`)
 - #143744 (Properly track the depth when expanding free alias types)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35 tgross35 mentioned this pull request Jul 11, 2025
Merged
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143762 - tgross35:rollup-n9t27c6, r=tgross35
cdac44e 
Rollup of 7 pull requests

Successful merges:

 - #140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - #143642 (stdarch subtree update)
 - #143707 (Fix `--skip-std-check-if-no-download-rustc`)
 - #143722 (Make some "safe" llvm ops actually sound)
 - #143728 (Resolve refactor: extraction of `finalize_module_binding` and `single_import_can_define_name`)
 - #143742 (Rework borrowing suggestions to use `Expr` instead of just `Span`)
 - #143744 (Properly track the depth when expanding free alias types)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6debe03 into rust-lang:master Jul 11, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 11, 2025
rust-timer added a commit that referenced this pull request Jul 11, 2025
@rust-timer
Unrolled build for #140136
90ed755 
Rollup merge of #140136 - dpaoliello:arm64winci, r=Kobzol

Add an aarch64-msvc build running on ARM64 Windows

Resurrecting #126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? ``@Kobzol``

try-job: `*aarch64-msvc*`
@dpaoliello dpaoliello deleted the arm64winci branch July 11, 2025 18:22
Kobzol pushed a commit to Kobzol/stdarch that referenced this pull request Jul 13, 2025
@bors
Auto merge of #143762 - tgross35:rollup-n9t27c6, r=tgross35
5b5502f 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - rust-lang/rust#143642 (stdarch subtree update)
 - rust-lang/rust#143707 (Fix `--skip-std-check-if-no-download-rustc`)
 - rust-lang/rust#143722 (Make some "safe" llvm ops actually sound)
 - rust-lang/rust#143728 (Resolve refactor: extraction of `finalize_module_binding` and `single_import_can_define_name`)
 - rust-lang/rust#143742 (Rework borrowing suggestions to use `Expr` instead of just `Span`)
 - rust-lang/rust#143744 (Properly track the depth when expanding free alias types)

r? `@ghost`
`@rustbot` modify labels: rollup
@Noratrieb Noratrieb mentioned this pull request Aug 20, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

@Kobzol Kobzol

Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
8 participants
@dpaoliello @rust-log-analyzer @bors @Kobzol @ZuseZ4 @programmerjake @matthiaskrgr @rustbot