Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Apr 2, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

sayantn and others added 30 commits March 5, 2025 05:34
The test was failing on aarch64-apple-darwin.
only errors that are string arrays are intended to be shown
to the user, other errors are bugs,
and will be shown in the console as usual.
specifically, `storage.js` is not loaded during `rustdoc-js`
and `rustdoc-js-std` tests.
This test is intended to demonstrate that a particular macro-argument span
doesn't get lost during span-refinement, but it turns out that span-extraction
currently doesn't yield any MIR spans for this position.

This patch therefore tweaks the test to add a function call in that position,
so that it still remains relevant to span refinement.
This is a way to shrink call spans that doesn't involve mixing different spans,
and avoids overlap with argument spans.

This patch also removes some low-value comments that were causing rustfmt to
ignore the match arms.
Update netbsd.md

Update netbsd.md
Zalathar added 3 commits April 2, 2025 13:10
…crum

Update mdbook to 0.4.48

This brings in several updates. Two significant ones are to halve the search index size, and the other introduces major changes to footnote rendering.

Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0448
…piler-errors

Tell rustfmt to use the 2024 edition in ./x.py fmt

Most crates in this repo have been moved to the 2024 edition already. This also allows removing a rustfmt exclusion for a cg_clif test.
move autodiff from EnzymeAD/Enzyme to our rust-lang/Enzyme soft-fork

In rust-lang/team#1665 we decided to have a soft-fork of Enzyme, to be able to merge e.g. CI, docs, or cmake improvements if upstream is not interested in them. We don't intend to merge logic/code changes. It also seems generally preferable if we clone submodules from a rust-lang repo, instead of an external org. We don't build or checkout Enzyme yet by default, so this should be a safe rollup.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Apr 2, 2025
@Zalathar
Copy link
Contributor Author

Zalathar commented Apr 2, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit ea51a1c has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
@bors
Copy link
Collaborator

bors commented Apr 2, 2025

⌛ Testing commit ea51a1c with merge c9cd707...

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing c9cd707 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2025
@bors bors merged commit c9cd707 into rust-lang:master Apr 2, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 70dab5a (parent) -> c9cd707 (this PR)

Test differences

Show 19 test diffs

Stage 1

  • [crashes] tests/crashes/134334.rs: pass -> [missing] (J2)
  • [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs: [missing] -> pass (J2)
  • [ui] tests/ui/self/dyn-dispatch-do-not-mix-normalized-and-unnormalized.rs: [missing] -> pass (J2)
  • [ui] tests/ui/simd/empty-simd-vector-in-operand.rs: [missing] -> pass (J2)
  • [ui] tests/ui/traits/object/suggestion-trait-object-issue-139174.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J0)
  • [ui] tests/ui/simd/empty-simd-vector-in-operand.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J0)
  • [ui] tests/ui/self/dyn-dispatch-do-not-mix-normalized-and-unnormalized.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/object/suggestion-trait-object-issue-139174.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs: [missing] -> pass (J3)
  • [ui] tests/ui/simd/empty-simd-vector-in-operand.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/134334.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/134334.rs: ignore (only executed when the architecture is x86_64) -> [missing] (J5)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-2
  • J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J2: x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-3
  • J3: test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-19-1, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J4: test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J5: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1

Job duration changes

  1. dist-x86_64-apple: 6961.8s -> 9029.6s (29.7%)
  2. aarch64-apple: 3414.6s -> 4036.2s (18.2%)
  3. dist-powerpc64le-linux: 9436.5s -> 9853.0s (4.4%)
  4. mingw-check: 1228.7s -> 1281.8s (4.3%)
  5. dist-various-1: 4398.8s -> 4584.1s (4.2%)
  6. x86_64-msvc-ext2: 5816.0s -> 5978.1s (2.8%)
  7. aarch64-gnu-debug: 4124.5s -> 4238.3s (2.8%)
  8. dist-x86_64-msvc: 6040.8s -> 6206.0s (2.7%)
  9. x86_64-gnu-aux: 5927.7s -> 6049.3s (2.1%)
  10. dist-loongarch64-musl: 5309.6s -> 5416.4s (2.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#135295 Check empty SIMD vector in inline asm a71e0be7ec62590802d23054dddf35aec5ddef5d (link)
#138003 Add the new amx target features and the movrs target fe… 46d8f7b16a29bc8369eaa190762b9a2af1614e1a (link)
#138823 rustc_target: RISC-V: add base I-related important extens… 18ce4f140382db89718b2ebfe653e8fd699c804f (link)
#138913 Remove even more instances of @ts-expect-error from search.… 78b5d24fb63418c2eeb78dff5479310de0e86bad (link)
#138941 Do not mix normalized and unnormalized caller bounds when c… 1c256fb50262d6b19e88215640793e95f4117bdb (link)
#139060 replace commit placeholder in vendor status with actual com… c15f4dc4a13921ce7d453685dd2bd252fc80745d (link)
#139102 coverage: Avoid splitting spans during span extraction/refi… 5c783d069a9a3618c4f730e7b3fade2333a99e47 (link)
#139191 small opaque type/borrowck cleanup 118b18c89503fd33b3a0cddba91fecbb17287adf (link)
#139200 Skip suggest impl or dyn when poly trait is not a real trait 98b4cf17767cc50d818c2c2ee349759ac9d490af (link)
#139208 fix dead link netbsd.md 4ff5088a8044636bb6da5a59e4fc8d9082b3ceef (link)
#139210 chore: remove redundant backtick aa55002d939145b8d0a7657a6e80dadbd7816d5a (link)
#139212 Update mdbook to 0.4.48 a1f95d721226504dac3ea9e99712f600bc8d9aa5 (link)
#139214 Tell rustfmt to use the 2024 edition in ./x.py fmt 6fa62628542e1a01c1ad5a7103a353f940b0ccdf (link)
#139225 move autodiff from EnzymeAD/Enzyme to our rust-lang/Enzyme … cf8e0f91aa84474060aa29237462b4d1d9f905e9 (link)

previous master: 70dab5a27c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c9cd707): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 1
Regressions ❌
(secondary)
0.3% [0.2%, 0.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 1

Max RSS (memory usage)

Results (primary 0.4%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
2.9% [1.3%, 5.1%] 11
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
-4.0% [-8.4%, -1.0%] 8
All ❌✅ (primary) 0.4% [-0.9%, 1.6%] 2

Cycles

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.398s -> 775.08s (0.09%)
Artifact size: 365.94 MiB -> 365.94 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-search Area: Rustdoc's search feature merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.