Implement pin!() using super let
#139114
Open
Implement pin!() using super let
#139114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
This comment has been minimized.
This comment has been minimized.
kpreid
reviewed
Mar 29, 2025
|
☔ The latest upstream changes (presumably #138740) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
|
r? compiler |
|
☔ The latest upstream changes (presumably #139279) made this pull request unmergeable. Please resolve the merge conflicts. |
m-ou-se
commented
Apr 10, 2025
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 10, 2025
Remove unnecessary `mut` in test. The value is moved in `pin!()`, so the binding doesn't need to be `mut` itself. (Rustc doesn't warn about this due to the current hacky implementation of `pin!()`. That is fixed by rust-lang#139114.)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
Rollup merge of rust-lang#139626 - m-ou-se:mut, r=lqd Remove unnecessary `mut` in test. The value is moved in `pin!()`, so the binding doesn't need to be `mut` itself. (Rustc doesn't warn about this due to the current hacky implementation of `pin!()`. That is fixed by rust-lang#139114.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue for super let: #139076
This uses
super letto implementpin!().This means we can remove the hack we had to put in to fix #138596.
It also means we can remove the original hack to make
pin!()work, which used a questionable public-but-unstable field rather than a proper private field.While
super letis still unstable and subject to change, it seems safe to assume that future Rust will always have a way to expresspin!()in a compatible way, consideringpin!()is already stable.It'd help the experiment to have
pin!()usesuper let, so we can get some more experience with it.