Don't drop Rvalue::WrapUnsafeBinder during GVN
#137864
Open
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
unsafe-binder-gvn
branch
from
e4e50d0 to
70b0c3e
Compare
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
oli-obk
reviewed
Mar 5, 2025
| return self.simplify_operand(op, location); | ||
| Rvalue::WrapUnsafeBinder(ref mut op, ty) => { | ||
| let value = self.simplify_operand(op, location)?; | ||
| Value::WrapUnsafeBinder(value, ty) |
There was a problem hiding this comment.
why not just produce a transmute cast?
There was a problem hiding this comment.
o true :3 that works
oli-obk
added
S-waiting-on-author
|
r=me with WrapUnsafeBinder removed |
compiler-errors
force-pushed
the
unsafe-binder-gvn
branch
from
70b0c3e to
33621bd
Compare
|
Is there a reason why we can't use transmute lowering generally in runtime MIR? |
|
errs tried it out and it didn't actually simplify things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and instead use
Value::WrapUnsafeBinderto properly propagate consts throughwrap_binder!()in GVN.Fixes #137846
r? oli-obk