std: move process implementations to sys
#136929
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
O-hermit
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
move_process_pal
branch
from
a3a3339 to
484706e
Compare
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
move_process_pal
branch
from
484706e to
5ce9e2c
Compare
|
☔ The latest upstream changes (presumably #137046) made this pull request unmergeable. Please resolve the merge conflicts. |
joboet
force-pushed
the
move_process_pal
branch
from
5ce9e2c to
fb1751f
Compare
|
☔ The latest upstream changes (presumably #137163) made this pull request unmergeable. Please resolve the merge conflicts. |
joboet
force-pushed
the
move_process_pal
branch
from
fb1751f to
26fd9bf
Compare
|
☔ The latest upstream changes (presumably #137446) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -289,6 +288,14 @@ pub fn truncate_utf16_at_nul(v: &[u16]) -> &[u16] { | |||
| } | |||
| } | |||
|
|
|||
| pub fn ensure_no_nuls<T: AsRef<OsStr>>(s: T) -> crate::io::Result<T> { | |||
| if s.as_ref().encode_wide().any(|b| b == 0) { | |||
There was a problem hiding this comment.
Hm, are we using this for soundness anywhere? The AsRef<OsStr> conversion could e.g. return different results spuriously which would be a problem if we are.
There was a problem hiding this comment.
Luckily that's not the case, we only use this with trusted types. But I agree that this isn't great, I'll try to find a better solution in another PR.
|
r=me with a rebase |
As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.
joboet
force-pushed
the
move_process_pal
branch
from
26fd9bf to
57462c0
Compare
|
☔ The latest upstream changes (presumably #138366) made this pull request unmergeable. Please resolve the merge conflicts. |
As per #117276, this moves the implementations of
Processand friends out of thepalmodule and into thesysmodule, removing quite a lot of error-prone#[path]imports in the process (hah, get it ;-)). I've also made thezirconmodule a dedicated submodule ofpal::unix, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications insys). Also, theensure_no_nulsfunction on Windows now lives insys::pal::windows– it's not specific to processes and shared by the argument implementation.