Remove opt_item_ident
#136061
Closed
Remove opt_item_ident
#136061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Urgau
reviewed
Jan 26, 2025
| @@ -600,7 +600,7 @@ pub(crate) enum PtrNullChecksDiag<'a> { | |||
| label: Span, | |||
| }, | |||
| #[diag(lint_ptr_null_checks_fn_ret)] | |||
| FnRet { fn_name: Ident }, | |||
| FnRet { fn_name: Symbol }, | |||
There was a problem hiding this comment.
If a function is named async in edition 2018 it should be reported as r#async, but symbols don't carry the "raw-ness" unlike ident.
Are we fine having inaccurate item name in some edge-cases ?
There was a problem hiding this comment.
oh good point
of course we don't have any tests for this lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only usages in diagnostics can be replaced by
opt_item_nameordef_ident_span.