Implement MIR const trait stability checks #136055
Open
+234
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-ovmyztlkptmk
branch
from
7081449 to
65c9b8a
Compare
RalfJung
reviewed
Jan 25, 2025
| const_eval_unmarked_const_fn_exposed = `{$def_path}` cannot be (indirectly) exposed to stable | ||
| .help = either mark the callee as `#[rustc_const_stable_indirect]`, or the caller as `#[rustc_const_unstable]` | ||
| const_eval_unmarked_const_item_exposed = `{$def_path}` cannot be (indirectly) exposed to stable | ||
| .help = either mark the item as `#[rustc_const_stable_indirect]`, or the caller as `#[rustc_const_unstable]` |
There was a problem hiding this comment.
This is ambiguous about which item should be marked as such -- the caller or the callee.
There was a problem hiding this comment.
I'll revert it back to callee since a trait can also be called the callee.
| @@ -694,6 +695,88 @@ impl<'tcx> Visitor<'tcx> for Checker<'_, 'tcx> { | |||
| } | |||
| }; | |||
|
|
|||
| let check_stability = |this: &mut Self, def_id| { | |||
There was a problem hiding this comment.
Suggested change
| let check_stability = |this: &mut Self, def_id| { | |
| // Check the const stability of the given item (fn or trait). | |
| let check_item_stability = |this: &mut Self, def_id| { |
Could this be a proper method or would that duplicate too many arguments?
There was a problem hiding this comment.
Then maybe this should be check_callee_stability as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rust-lang/project-const-traits#16
cc @rust-lang/project-const-traits
r? @RalfJung