Rollup of 11 pull requests #135519
Merged
Rollup of 11 pull requests #135519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also makes the rust.docs-minification option work as advertised in config.toml nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs. mitegates rust-lang#135345
Clang will not respect this value in cross configurations.
A clone-like function in a function that takes as an argument the type that it returns. However, functions that return a type variable are not counted as clone-line. Because we're not unifying the whole function at once, a function like `U -> T` would otherwise be counted as "clone-like" because the generics will just unify with anything when done seperatly. Co-authored-by: Michael Howell <[email protected]>
…onditionally const
…ppress spurious errors
…utlives assumptions in borrowck
bootstrap: do not rely on LIBRARY_PATH env variable Closes rust-lang#134811 try-job: test-various try-job: armhf-gnu try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: aarch64-apple try-job: x86_64-msvc try-job: i686-msvc try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: i686-mingw
Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck Otherwise we're just randomly registering these region relations into the infcx which isn't good r? lcnr
…atch, r=BoxyUwU Improve `DispatchFromDyn` and `CoerceUnsized` impl validation * Disallow arbitrary 1-ZST fields in `DispatchFromDyn` -- only `PhantomData`, and 1-ZSTs that mention no params (which is needed to support, e.g., the `Global` alloctor in `Box<T, U = Global>`). * Don't allow coercing between non-ZSTs to ZSTs (since the previous check wasn't actually checking the field tys were the same before checking the layout...) * Normalize the field before checking it's `PhantomData`. Fixes rust-lang#135215 Fixes rust-lang#135214 Fixes rust-lang#135220 r? ```@BoxyUwU``` or reassign
…rrors, r=oli-obk Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors Fixes rust-lang#135208 r? oli-obk
…-sort-134935, r=notriddle for purely return-type based searches, deprioritize clone-like functions closes rust-lang#134935
…ication, r=notriddle re-add --disable-minification to rustdoc this also makes the rust.docs-minification option work as advertised in config.toml nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs. mitegates rust-lang#135345 It was removed in rust-lang@f9e1f6f.
…r=lcnr Make sure we can produce `ConstArgHasWrongType` errors for valtree consts I forgot about `ty::ConstKind::Value` in rust-lang#134771. The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here. Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added. r? ```@lcnr``` or ```@BoxyUwU```
…t-syntactical, r=oli-obk,RalfJung Enforce syntactical stability of const traits in HIR This PR enforces what I'm calling *syntactical* const stability of traits. In other words, it enforces the ability to name `~const`/`const` traits in trait bounds in various syntax positions in HIR (including in the trait of an impl header). This functionality is analogous to the *regular* item stability checker, which is concerned with making sure that you cannot refer to unstable items by name, and is implemented as an extension of that pass. This is separate from enforcing the *recursive* const stability of const trait methods, which is implemented in MIR and runs on MIR bodies. That will require adding a new `NonConstOp` to the const checker and probably adjusting some logic to deduplicate redundant errors. However, this check is separate and necessary for making sure that users don't add `~const`/`const` bounds to items when the trait is not const-stable in the first place. I chose to separate enforcing recursive const stability out of this PR to make it easier to review. I'll probably open a follow-up following this one, blocked on this PR. r? `@RalfJung` cc `@rust-lang/project-const-traits`
…const, r=RalfJung Do not consider traits that have unsatisfied const conditions to be conditionally const This will improve error messages as we continue to constify traits, since we don't want to start calling things "conditionally const" if they aren't implemented with a const impl anyways. The only case that this affects today is `Deref` since that's one of the only constified traits in the standard library :) r? RalfJung
…e-133484, r=GuillaumeGomez fix underlining of hovered intra-doc links. fixes rust-lang#133484 i'm not sure how to create a test case for this, or if that is even possible.
Fix clippy lints in rustdoc Some more clippy lint fixes. r? `@notriddle`
rustbot
added
A-run-make
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 93ba568ab9 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
1 task
|
Finished benchmarking commit (00ded39): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.182s -> 763.74s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
DispatchFromDynandCoerceUnsizedimpl validation #135228 (ImproveDispatchFromDynandCoerceUnsizedimpl validation)LayoutError::ReferencesErrorto suppress spurious errors #135264 (Consider more erroneous layouts asLayoutError::ReferencesErrorto suppress spurious errors)ConstArgHasWrongTypeerrors for valtree consts #135380 (Make sure we can produceConstArgHasWrongTypeerrors for valtree consts)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup