re-add --disable-minification to rustdoc #135353
Open
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
notriddle
approved these changes
Jan 11, 2025
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-disable-minification
branch
from
d62a16f to
706fa7c
Compare
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-disable-minification
branch
from
706fa7c to
e0463df
Compare
This comment has been minimized.
This comment has been minimized.
fmease
added
S-waiting-on-author
this also makes the rust.docs-minification option work as advertised in config.toml nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs. mitegates rust-lang#135345
lolbinarycat
force-pushed
the
rustdoc-disable-minification
branch
from
e0463df to
d4057e8
Compare
|
This PR modifies cc @jieyouxu |
| FlagMulti, | ||
| "", | ||
| "disable-minification", | ||
| "diable the minification of CSS/JS files", |
There was a problem hiding this comment.
Suggested change
| "diable the minification of CSS/JS files", | |
| "disable the minification of CSS/JS files", |
| @@ -194,7 +194,7 @@ Options: | |||
| --doctest-compilation-args add arguments to be used when compiling doctests | |||
|
|
|||
| --disable-minification | |||
| removed | |||
| diable the minification of CSS/JS files | |||
There was a problem hiding this comment.
Suggested change
| diable the minification of CSS/JS files | |
| disable the minification of CSS/JS files |
|
The rustdoc team discussed about it in the last zulip meeting and agreed with this re-add. One thing though: please add a disclaimer to the flag help message to mention it's perma unstable. |
|
yeah, and the disclaimer should also say that it shouldn't be used with services that cache, like docs.rs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also makes the rust.docs-minification option work as advertised in config.toml
nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs.
mitegates #135345
It was removed in f9e1f6f.