Begin to implement type system layer of unsafe binders #134625

compiler-errors · 2024-12-21T17:14:27Z

Mostly TODOs, but there's a lot of match arms that are basically just noops so I wanted to split these out before I put up the MIR lowering/projection part of this logic.

r? oli-obk

Tracking:

Tracking issue for unsafe binder types #130516

rustbot · 2024-12-21T17:14:37Z

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

HIR ty lowering was modified

cc @fmease

oli-obk

Feels like some of the todo! should be reachable even now, but seems fine to address them individually or together with mir support

compiler/rustc_hir_analysis/src/variance/constraints.rs

compiler/rustc_hir_typeck/src/expr.rs

compiler/rustc_middle/src/ty/print/pretty.rs

compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs

compiler/rustc_ty_utils/src/needs_drop.rs

compiler/rustc_type_ir/src/ty_kind.rs

tests/ui/symbol-names/basic.legacy.stderr

tests/ui/unsafe-binders/simple.rs

tests/ui/unsafe-binders/mismatch.rs

oli-obk · 2024-12-23T07:14:10Z

@bors r+

bors · 2024-12-23T07:14:12Z

📌 Commit 9a1c5eb has been approved by oli-obk

It is now in the queue for this repository.

bors · 2024-12-24T00:51:55Z

⌛ Testing commit 9a1c5eb with merge f334342...

bors · 2024-12-24T03:32:02Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing f334342 to master...

rust-timer · 2024-12-24T04:49:06Z

Finished benchmarking commit (f334342): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.437s -> 760.851s (-0.34%)
Artifact size: 330.62 MiB -> 330.65 MiB (0.01%)

…=oli-obk Begin to implement type system layer of unsafe binders Mostly TODOs, but there's a lot of match arms that are basically just noops so I wanted to split these out before I put up the MIR lowering/projection part of this logic. r? oli-obk Tracking: - rust-lang#130516

Rustc has started implementing `UnsafeBinder`: - rust-lang/rust#134625 - rust-lang/rust#130516 Only the enums variants have been added for now, semantics is TBD.

rustbot assigned oli-obk Dec 21, 2024