Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #133654

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Update cargo #133654

merged 1 commit into from
Nov 30, 2024

Conversation

weihanglo
Copy link
Member

8 commits in 4c39aaff66862cc0da52fe529aa1990bb8bb9a22..3908f64086a3d7b9af8d87b4da2bd100776c3e61
2024-11-25 16:36:17 +0000 to 2024-11-29 17:32:44 +0000

@weihanglo weihanglo self-assigned this Nov 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Nov 29, 2024

📌 Commit 2ba7d68 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2024
@bors
Copy link
Contributor

bors commented Nov 30, 2024

⌛ Testing commit 2ba7d68 with merge 76f3ff6...

@bors
Copy link
Contributor

bors commented Nov 30, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 76f3ff6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2024
@bors bors merged commit 76f3ff6 into rust-lang:master Nov 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 30, 2024
@weihanglo weihanglo deleted the update-cargo branch November 30, 2024 04:24
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (76f3ff6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.5%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-0.7%, -0.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.7% [-0.7%, -0.7%] 1

Cycles

Results (secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.3%, -3.7%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.861s -> 773.805s (-0.01%)
Artifact size: 332.29 MiB -> 332.32 MiB (0.01%)

nikic pushed a commit to nikic/rust that referenced this pull request Nov 30, 2024
…ihanglo"

This reverts commit 76f3ff6, reversing
changes made to 1fc691e.

The new pgo_works test fails when rust is built without profiling
support, including in CI on x86_64-gnu-aux.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
Revert "Auto merge of rust-lang#133654 - weihanglo:update-cargo, r=weihanglo"

This reverts commit 76f3ff6, reversing changes made to 1fc691e.

The new pgo_works test fails when rust is built without profiling support, including in CI on x86_64-gnu-aux. See rust-lang#133499 (comment) for how this happened.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants