[IT'S NOT TIME YET] Disarm time 💣 (diagnostics)
#133245
Draft
+2
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
the
S-blocked
rustbot
added
S-waiting-on-review
jieyouxu
removed
the
S-waiting-on-review
|
now we need a second timer to remind us to merge this 😄 |
jieyouxu
force-pushed
the
disarm-time-bomb
branch
from
9fe05c0 to
58a0bc5
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
jieyouxu
force-pushed
the
disarm-time-bomb
branch
from
58a0bc5 to
61c02cb
Compare
Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu" This reverts commit 26f75a6, reversing changes made to 2572e0e. Imports are modified to fix merge conflicts and remove unused ones.
jieyouxu
force-pushed
the
disarm-time-bomb
branch
from
61c02cb to
2f2fc50
Compare
jieyouxu
changed the title
time bomb (diagnostics)time 💣 (diagnostics)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129461.
Reverts Emit specific message for time<=0.3.35 #129343 to defuse a time 💣.
This reverts commit 26f75a6, reversing changes made to 2572e0e.
(Just opened to have a PR open to make it less likely we forgor)
r? @ghost