Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #128608

Closed
wants to merge 16 commits into from
Closed

Rollup of 6 pull requests #128608

wants to merge 16 commits into from

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 3, 2024

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

spastorino and others added 16 commits July 23, 2024 00:29
@spastorino
Stabilize unsafe extern blocks (RFC 3484)
8366c7f
@Oneirical
rewrite reproducible-build-2 to rmake
b485dd1
@Oneirical
rewrite stable-symbol-names to rmake
94da7b1
@sayantn
Update stdarch
f373ff3
@sayantn
Delete issue-120720-reduce-nan.rs
e3b9851 
This file tests for UB in `reduce_add`, but those are reimplemented by explicitly using the associativity specified by Intel
@scottmcm
Implement UncheckedIterator directly for RepeatN
77ca30f
@oli-obk @jieyouxu
Assert that all attributes are actually checked via `CheckAttrVisitor…
ed010dd 
…` and aren't accidentally usable on completely unrelated HIR nodes

Co-authored-by: Jieyou Xu <[email protected]>
@oli-obk @jieyouxu
Add test for coroutine attribute
33cb334
@ChrisDenton
Update run-make/used to use any_symbol_contains
b564b70
@ChrisDenton
Remove BAR for run-make/used.rs
eb45146
@tgross35
Rollup merge of rust-lang#127095 - Oneirical:testiary-education, r=ji…
ac06548 
…eyouxu

Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Needs try-jobs.

try-job: x86_64-msvc
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: i686-msvc
try-job: x86_64-mingw
@tgross35
Rollup merge of rust-lang#127921 - spastorino:stabilize-unsafe-extern…
16e6cd2 
…-blocks, r=compiler-errors

Stabilize unsafe extern blocks (RFC 3484)

# Stabilization report

## Summary

This is a tracking issue for the RFC 3484: Unsafe Extern Blocks

We are stabilizing `#![feature(unsafe_extern_blocks)]`, as described in [Unsafe Extern Blocks RFC 3484](rust-lang/rfcs#3484). This feature makes explicit that declaring an extern block is unsafe. Starting in Rust 2024, all extern blocks must be marked as unsafe. In all editions, items within unsafe extern blocks may be marked as safe to use.

RFC: rust-lang/rfcs#3484
Tracking issue: rust-lang#123743

## What is stabilized

### Summary of stabilization

We now need extern blocks to be marked as unsafe and items inside can also have safety modifiers (unsafe or safe), by default items with no modifiers are unsafe to offer easy migration without surprising results.

```rust
unsafe extern {
    // sqrt (from libm) may be called with any `f64`
    pub safe fn sqrt(x: f64) -> f64;

    // strlen (from libc) requires a valid pointer,
    // so we mark it as being an unsafe fn
    pub unsafe fn strlen(p: *const c_char) -> usize;

    // this function doesn't say safe or unsafe, so it defaults to unsafe
    pub fn free(p: *mut core::ffi::c_void);

    pub safe static IMPORTANT_BYTES: [u8; 256];

    pub safe static LINES: SyncUnsafeCell<i32>;
}
```

## Tests

The relevant tests are in `tests/ui/rust-2024/unsafe-extern-blocks`.

## History

- rust-lang#124482
- rust-lang#124455
- rust-lang#125077
- rust-lang#125522
- rust-lang#126738
- rust-lang#126749
- rust-lang#126755
- rust-lang#126757
- rust-lang#126758
- rust-lang#126756
- rust-lang#126973
- rust-lang#127535
- rust-lang/rustfmt#6204

## Unresolved questions

I am not aware of any unresolved questions.
@tgross35
Rollup merge of rust-lang#128466 - sayantn:stdarch-update, r=tgross35
3bd24f4 
Update the stdarch submodule

cc `@tgross35` `@Amanieu`
r? `@tgross35`

try-job: x86_64-rust-for-linux
try-job: test-various
try-job: dist-x86_64-linux
@tgross35
Rollup merge of rust-lang#128530 - scottmcm:repeat-n-unchecked, r=joboet
a8e58c3 
Implement `UncheckedIterator` directly for `RepeatN`

This just pulls the code out of `next` into `next_unchecked`, rather than making the `Some` and `unwrap_unchecked`ing it.

And while I was touching it, I added a codegen test that `array::repeat` for something that's just `Clone`, not `Copy`, still ends up optimizing to the same thing as `[x; n]`: <https://rust.godbolt.org/z/YY3a5ajMW>.
@tgross35
Rollup merge of rust-lang#128581 - jieyouxu:checked-attr, r=nnethercote
6b3160e 
Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes

`@oli-obk's` rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away.
Based on rust-lang#128402.

This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in `rustc_passes::CheckAttrVisitor`.

r? `@nnethercote` (since you were the reviewer of the original PR)
@tgross35
Rollup merge of rust-lang#128603 - ChrisDenton:used, r=jieyouxu
74cc27f 
Update run-make/used to use `any_symbol_contains`

This makes it so we don't need `nm` or `llvm-nm`.

I also tested that `BAR` is removed. I'm not sure if this is wanted though.
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 3, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 3, 2024

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Aug 3, 2024

📌 Commit 74cc27f has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2024
@bors
Auto merge of rust-lang#128608 - tgross35:rollup-kibt0o5, r=tgross35
cacd19d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake)
 - rust-lang#127921 (Stabilize unsafe extern blocks (RFC 3484))
 - rust-lang#128466 (Update the stdarch submodule)
 - rust-lang#128530 (Implement `UncheckedIterator` directly for `RepeatN`)
 - rust-lang#128581 (Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes)
 - rust-lang#128603 (Update run-make/used to use `any_symbol_contains`)

Failed merges:

 - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Aug 3, 2024

⌛ Testing commit 74cc27f with merge cacd19d...

@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling std v0.0.0 (/checkout/library/std)
error: formatting may not be suitable for sub-register argument
  --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:82:18
   |
82 |         "movnti [{p}], {a}",
   |                  ^^^
83 |         p = in(reg) mem_addr,
   |
   |
   = help: use `{0:e}` to have the register formatted as `eax` (for 32-bit values)
   = help: or use `{0:r}` to keep the default formatting of `rax` (for 64-bit values)
   = note: `-D asm-sub-register` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(asm_sub_register)]`
[RUSTC-TIMING] core test:false 13.478
error: could not compile `core` (lib) due to 1 previous error
Build completed unsuccessfully in 0:40:55
  local time: Sat Aug  3 18:46:36 UTC 2024

@bors
Copy link
Contributor

bors commented Aug 3, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2024
@tgross35 tgross35 mentioned this pull request Aug 3, 2024
Merged
@tgross35 tgross35 closed this Aug 3, 2024
@tgross35 tgross35 deleted the rollup-kibt0o5 branch August 3, 2024 18:53
@sayantn sayantn mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tgross35 @bors @rust-log-analyzer @rustbot @spastorino @Oneirical @sayantn @scottmcm @oli-obk @ChrisDenton