Add `f16` and `f128` math functions #128417

tgross35 · 2024-07-31T00:23:00Z

This adds intrinsics and math functions for f16 and f128 floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

Bors merged #127027 too soon without going through full CI, so Mark had to drop the commits from master. This is a new PR with the same changes.

r? @dtolnay
@rustbot label +F-f16_and_f128

tgross35 · 2024-07-31T00:27:39Z

This has the exact same commits as in #127027.

@bors r=dtolnay

bors · 2024-07-31T00:27:41Z

📌 Commit d64bbb1 has been approved by dtolnay

It is now in the queue for this repository.

tgross35 · 2024-07-31T00:29:23Z

Thanks dtolnay, sorry for all the noise 🙂

Add `f16` and `f128` math functions This adds intrinsics and math functions for `f16` and `f128` floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128402 (Attribute checking simplifications) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128417 (Add `f16` and `f128` math functions) r? `@ghost` `@rustbot` modify labels: rollup

Add `f16` and `f128` math functions This adds intrinsics and math functions for `f16` and `f128` floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128402 (Attribute checking simplifications) - rust-lang#128417 (Add `f16` and `f128` math functions) r? `@ghost` `@rustbot` modify labels: rollup

Add `f16` and `f128` math functions This adds intrinsics and math functions for `f16` and `f128` floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123813 (Add `REDUNDANT_IMPORTS` lint for new redundant import detection) - rust-lang#127159 (match lowering: Hide `Candidate` from outside the lowering algorithm) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128296 (Update target-spec metadata for loongarch64 targets) - rust-lang#128417 (Add `f16` and `f128` math functions) - rust-lang#128431 (Add myself as VxWorks target maintainer for reference) - rust-lang#128437 (improve bootstrap to allow selecting llvm tools individually) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2024-07-31T18:47:54Z

@bors r-, failed the rollup in #128439 (comment)

tgross35 · 2024-07-31T18:52:10Z

@bors r-

tgross35 · 2024-07-31T19:11:51Z

Android presumably failed because I did not correctly gate the shims in library/std/src/sys/pal/unix/android.rs on has_reliable_{f16,f128}_math. #128416 is actually removing these shims, so I will just wait on that.

bors · 2024-08-01T11:31:20Z

☔ The latest upstream changes (presumably #128481) made this pull request unmergeable. Please resolve the merge conflicts.

Since LLVM <https://reviews.llvm.org/D99439> (4c7f820, "Update @llvm.powi to handle different int sizes for the exponent"), the size of the integer can be specified for the `powi` intrinsic. Make use of this so it is more obvious that integer size is consistent across all float types. This feature is available since LLVM 13 (October 2021). Based on bootstrap we currently support >= 17.0, so there should be no support problems.

These already exist in the compiler. Expose them in core so we can add their library functions.

This adds missing functions for math operations on the new float types. Platform support is pretty spotty at this point, since even platforms with generally good support can be missing math functions. `std/build.rs` is updated to reflect this.

Due to a LLVM bug, `f128` math functions link successfully but LLVM chooses the wrong symbols (`long double` symbols rather than those for binary128). Since this is a notable problem that may surprise a number of users, add a note about it. Link: llvm/llvm-project#44744

tgross35 · 2024-08-01T19:43:37Z

#128416 merged so I rebased on top of that, which allowed dropping the android workarounds to call the intrinsics directly. No other changes.

@rustbot ready

dtolnay · 2024-08-06T19:52:32Z

@bors r+

bors · 2024-08-06T19:52:35Z

📌 Commit 8e2ca0c has been approved by dtolnay

It is now in the queue for this repository.

tgross35 · 2024-08-06T19:58:53Z

Thanks!

Add `f16` and `f128` math functions This adds intrinsics and math functions for `f16` and `f128` floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

Rollup of 7 pull requests Successful merges: - rust-lang#128107 (Migrate `raw-dylib-alt-calling-convention`, `raw-dylib-c` and `redundant-libs` `run-make` tests to rmake) - rust-lang#128362 (add test for symbol visibility of `#[naked]` functions) - rust-lang#128417 (Add `f16` and `f128` math functions) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128766 (Trivial grammar fix in const keyword docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#128417 - tgross35:f16-f128-math, r=dtolnay Add `f16` and `f128` math functions This adds intrinsics and math functions for `f16` and `f128` floating point types. Support is quite limited and some things are broken so tests don't run on many platforms, but this provides a starting point.

Kobzol · 2024-08-07T11:13:28Z

@rust-timer build f2082db

rust-timer · 2024-08-07T12:29:26Z

Finished benchmarking commit (f2082db): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	2
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	2

Max RSS (memory usage)

Results (primary -0.4%, secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-2.9%	[-3.3%, -2.4%]	4
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.877s -> 760.269s (-0.21%)
Artifact size: 336.90 MiB -> 336.97 MiB (0.02%)

Kobzol · 2024-08-07T12:40:39Z

New documentation added to stdlib.

@rustbot label: +perf-regression-triaged

rustbot assigned dtolnay Jul 31, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2024

dtolnay approved these changes Jul 31, 2024

View reviewed changes

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 5 pull requests #128423

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 4 pull requests #128428

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 7 pull requests #128439

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2024

tgross35 added 3 commits August 1, 2024 15:36

Add math intrinsics for f16 and f128

82b40c4

These already exist in the compiler. Expose them in core so we can add their library functions.

Add math functions for f16 and f128

fc43c01

This adds missing functions for math operations on the new float types. Platform support is pretty spotty at this point, since even platforms with generally good support can be missing math functions. `std/build.rs` is updated to reflect this.

tgross35 force-pushed the f16-f128-math branch from d64bbb1 to 8e2ca0c Compare August 1, 2024 19:39

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2024

dtolnay approved these changes Aug 6, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 6 pull requests #128765

Closed

This was referenced Aug 7, 2024

Rollup of 9 pull requests #128767

Closed

Rollup of 7 pull requests #128768

Merged

bors merged commit b3bfd66 into rust-lang:master Aug 7, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Aug 7, 2024

tgross35 deleted the f16-f128-math branch August 7, 2024 08:28

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Aug 7, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 7, 2024

zinkkkk mentioned this pull request Dec 4, 2024

f128 cmath functions broken in windows #133835

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `f16` and `f128` math functions #128417

Add `f16` and `f128` math functions #128417

tgross35 commented Jul 31, 2024 •

edited

Loading

tgross35 commented Jul 31, 2024

bors commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

bors commented Aug 1, 2024

tgross35 commented Aug 1, 2024

dtolnay commented Aug 6, 2024

bors commented Aug 6, 2024

tgross35 commented Aug 6, 2024

Kobzol commented Aug 7, 2024

This comment has been minimized.

rust-timer commented Aug 7, 2024

Kobzol commented Aug 7, 2024

Add f16 and f128 math functions #128417

Add f16 and f128 math functions #128417

Conversation

tgross35 commented Jul 31, 2024 • edited Loading

tgross35 commented Jul 31, 2024

bors commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

tgross35 commented Jul 31, 2024

bors commented Aug 1, 2024

tgross35 commented Aug 1, 2024

dtolnay commented Aug 6, 2024

bors commented Aug 6, 2024

tgross35 commented Aug 6, 2024

Kobzol commented Aug 7, 2024

This comment has been minimized.

rust-timer commented Aug 7, 2024

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Kobzol commented Aug 7, 2024

Add `f16` and `f128` math functions #128417

Add `f16` and `f128` math functions #128417

tgross35 commented Jul 31, 2024 •

edited

Loading