Update compiler_builtins to 0.1.114 #125016

nicholasbishop · 2024-05-11T14:01:27Z

The weak-intrinsics feature was removed from compiler_builtins in rust-lang/compiler-builtins#598, so dropped the compiler-builtins-weak-intrinsics feature from alloc/std/sysroot.

In rust-lang/compiler-builtins#593, some builtins for f16/f128 were added. These don't work for all compiler backends, so add a compiler-builtins-no-f16-f128 feature and disable it for cranelift and gcc.

rustbot · 2024-05-11T14:01:35Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-05-11T14:01:36Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

library/std/Cargo.toml

rustbot · 2024-05-12T15:37:24Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

klensy · 2024-05-12T16:06:25Z

There exist also #124886

nicholasbishop · 2024-05-12T18:14:12Z

Was this closed intentionally?

GuillaumeGomez · 2024-05-12T20:13:50Z

Oh wow, sorry didn't realize, no it wasn't on purpose!

bors · 2024-05-13T18:39:32Z

☔ The latest upstream changes (presumably #125074) made this pull request unmergeable. Please resolve the merge conflicts.

tgross35 · 2024-05-16T19:32:14Z

Note that #124886 does the same thing

beetrees · 2024-05-16T22:02:46Z

A rebase should fix the CI failure now that #123816 has been merged.

beetrees · 2024-05-16T22:41:44Z

It appears the CI failure is being caused by the bootstrap stage0 compiler. I guess it won't succeed until #123816 reaches stage0 then.

nicholasbishop · 2024-05-16T22:51:01Z

Makes sense. Is the compiler-builtins-no-f16-f128 feature still needed here? I'm unclear whether that mangling error was the only problem, or if it's still correct to turn off f16/f128 for gcc/cranelift.

tgross35 · 2024-05-16T23:14:30Z

Everything for f16/f128 needs to be turned off for the GCC and cranelift backends until they gain support (tracked at the issues at the bottom of this list #116909 (comment)). These types should stay enabled for the default LLVM backend, though.

tgross35 · 2024-05-16T23:28:31Z

It appears the CI failure is being caused by the bootstrap stage0 compiler. I guess it won't succeed until #123816 reaches stage0 then.

I'll ask on Zulip if we might be able to backport that to unblock these updates

…t-826-gc95abe94-3 / 3cf924b934322fd7b514600a7dc84fc517515346-4 : 595316b4006932405a63862d8fe65f71a6356293-3 https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/ecea8371..c95abe94 https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/3cf924b93432..595316b40069 Ran: ./tools/clang/scripts/upload_revision.py c95abe94aebb6862c3518e590343df3b7376ccee Ran: tools/clang/scripts/sync_deps.py Ran: tools/rust/gnrt_stdlib.py Due to https://crbug.com/357125724, revert rust-lang/rust#125016 for now. Bug: 348666967, 350341587, 355031922, 356172342, 357125724 Change-Id: I7953b33e8619c145105029f4adc30a0e767b5123 Binary-Size: Compiler update variation Fuchsia-Binary-Size: Compiler update variation Disable-Rts: True Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:lacros-arm64-generic-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:ios-catalyst,win-asan,android-official Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chromium/try:win-arm64-rel Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86 Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-rel Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Cq-Include-Trybots: chromium/try:android-rust-arm32-rel Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg Cq-Include-Trybots: chromium/try:android-rust-arm64-rel Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg Cq-Include-Trybots: chromium/try:linux-rust-x64-rel Cq-Include-Trybots: chromium/try:mac-rust-x64-dbg Cq-Include-Trybots: chromium/try:win-rust-x64-dbg Cq-Include-Trybots: chromium/try:win-rust-x64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753956 Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1337246} NOKEYCHECK=True GitOrigin-RevId: 546d096fdb2c93d74034005ff73ecd5ee6af2d23

The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in [1], we now provide these on all platforms. This also enables `f16` math since there are no further requirements. [1]: rust-lang#125016

…r=<try> Enable `f16` tests on platforms that were missing conversion symbols The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in rust-lang#125016, we now provide these on all platforms. This also enables `f16` math since there are no further requirements. try-job: dist-powerpc64-linux try-job: dist-powerpc64le-linux try-job: dist-riscv64-linux try-job: dist-aarch64-msvc

Enable `f16` on x86 and x86-64 Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. [1]: rust-lang#125016 try-job: i686-gnu try-job: dist-i586-gnu-i586-i686-musl

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. [1]: rust-lang#125016

Enable `f16` on x86 and x86-64 Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. [1]: rust-lang#125016 try-job: i686-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-gnu-distcheck

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747

Enable `f16` tests on x86 and x86-64 Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747 try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-gnu-distcheck

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747

Enable `f16` tests on x86 and x86-64 Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747 try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-gnu-distcheck

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747

Enable `f16` tests on x86 and x86-64 Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. `f16` math functions (`reliable_f16_math`) are still excluded because there is an LLVM crash for powi [2]. [1]: rust-lang#125016 [2]: llvm/llvm-project#105747 try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-apple-1

The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in [1], we now provide these on all platforms. This also enables `f16` math since there are no further requirements. Still excluded are platforms for which LLVM emits infinitely-recursing code. [1]: rust-lang#125016

…r=<try> Enable `f16` tests on platforms that were missing conversion symbols The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in rust-lang#125016, we now provide these on all platforms. This also enables `f16` math since there are no further requirements. try-job: arm-android try-job: test-various try-job: x86_64-fuchsia

…r=Mark-Simulacrum Enable `f16` tests on platforms that were missing conversion symbols The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in rust-lang#125016, we now provide these on all platforms. This also enables `f16` math since there are no further requirements. Still excluded are platforms for which LLVM emits infinitely-recursing code. try-job: arm-android try-job: test-various try-job: x86_64-fuchsia

…mulacrum Enable `f16` tests on platforms that were missing conversion symbols The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in rust-lang/rust#125016, we now provide these on all platforms. This also enables `f16` math since there are no further requirements. Still excluded are platforms for which LLVM emits infinitely-recursing code. try-job: arm-android try-job: test-various try-job: x86_64-fuchsia

The f16/f128 handling introduced as part of rust-lang/rustc#125016 (Update compiler_builtins to 0.1.114) broke compilation on LoongArch and RISC-V: error: internal compiler error: compiler/rustc_codegen_llvm/src/abi.rs: 126:22: unsupported float: Reg { kind: Float, size: Size(2 bytes) } thread 'rustc' panicked at compiler/rustc_codegen_llvm/src/abi.rs:126:22: Box<dyn Any> This should be resolved with LLVM 19, but we are still on LLVM 18. Revert 99e6a28 as a temporary workaround. Ref: rust-lang#125016

Musl Patch ========== riscv64gc-unknown-linux-musl gets promoted to tier 2 and `crt_static_default` is updated to false in rust-lang/rust#122049, which triggers rust-lang/rust#82521 (comment) when building stage2 library artifacts (riscv64gc-unknown-linux-gnu -> riscv64gc-unknown-linux-musl). I patched it to re-enable `crt_static_default` for `riscv64gc-unknown-linux-musl` to fix the build and align with the behavior on x86 Arch Linux, where `rust-musl` defaults to statically link musl. Wasm compiler_builtins bug ========================== Wasm compiler_builtins rlib from built `rust-wasm` package includes objects for host architecture(riscv64 in our case, and x86_64 for x86 Arch Linux). This is not reproducible for toolchains installed via rustup so I have reported it to Arch Linux: https://gitlab.archlinux.org/archlinux/packaging/packages/rust/-/issues/3 Complications when building 1.82.0 ================================== rust-lang/rust#125016 landed in 1.82.0, which breaks building rust 1.82.0 using our packaged rust 1.81.0. Compiling the new compiler_builtins component requires a rustc compiler that includes rust-lang/rust@99e6a28 but unfortunately 1.81.0 does not, leading to the following ICE: https://archriscv.felixc.at/.status/log.htm?url=logs/rust/rust-1:1.82.0-1.log internal compiler error: compiler/rustc_codegen_llvm/src/abi.rs:126:22: unsupported float: Reg { kind: Float, size: Size(2 bytes) } This is mitigated upstream by bumping stage0 to 1.82: rust-lang/rust#129268 (comment) So we need to first build 1.82.0 rustc once without the f16/f128 handling part in compiler_builtins, to get a compiler that is capable of handling f16/f128. And then we can use this compiler to compile compiler_builtins with f16/f128 handling. It's not easy to do so in one patch. The most easy way is to build and package rust 1.82.0 twice. This PR covers the first part and disable-f16-f128.diff will be removed in the second part.

…ss35 Update compiler_builtins to 0.1.114 The `weak-intrinsics` feature was removed from compiler_builtins in rust-lang/compiler-builtins#598, so dropped the `compiler-builtins-weak-intrinsics` feature from alloc/std/sysroot. In rust-lang/compiler-builtins#593, some builtins for f16/f128 were added. These don't work for all compiler backends, so add a `compiler-builtins-no-f16-f128` feature and disable it for cranelift and gcc.

rustbot assigned Mark-Simulacrum May 11, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2024

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 11, 2024

This comment has been minimized.

Sign in to view

nicholasbishop force-pushed the bishop-cb-112 branch from c6f9dc1 to 2bfbcfd Compare May 11, 2024 17:28

RalfJung reviewed May 12, 2024

View reviewed changes

library/std/Cargo.toml Outdated Show resolved Hide resolved

RalfJung mentioned this pull request May 12, 2024

Add builtins for f16/f128 float conversions rust-lang/compiler-builtins#593

Merged

nicholasbishop force-pushed the bishop-cb-112 branch from 2bfbcfd to 8b2ef5f Compare May 12, 2024 15:37

This comment has been minimized.

Sign in to view

GuillaumeGomez closed this May 12, 2024

GuillaumeGomez reopened this May 12, 2024

This comment has been minimized.

Sign in to view

tgross35 mentioned this pull request May 16, 2024

chore: Bump compiler_builtins #124886

Closed

nicholasbishop force-pushed the bishop-cb-112 branch from 8b2ef5f to e4f7d1c Compare May 16, 2024 22:08

This comment has been minimized.

Sign in to view

tgross35 mentioned this pull request May 16, 2024

Add v0 symbol mangling for f16 and f128 #123816

Merged

Patryk27 mentioned this pull request May 18, 2024

Very weird error when compiling a very basic program: __addsf3 multiple defenitions Rahix/avr-hal#541

Open

tgross35 mentioned this pull request Aug 22, 2024

Enable f16 tests on platforms that were missing conversion symbols #129385

Merged

tgross35 added a commit to tgross35/rust that referenced this pull request Aug 22, 2024

Enable f16 on x86 and x86-64

6a1e1e6

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now. [1]: rust-lang#125016

kxxt mentioned this pull request Oct 20, 2024

updpatch: rust 1:1.82.0-1 felixonmars/archriscv-packages#4243

Merged

0xdeafbeef mentioned this pull request Feb 18, 2025

-Zbuild-std shouldn't explode on compiler-builtins fragility #137222

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update compiler_builtins to 0.1.114 #125016

Update compiler_builtins to 0.1.114 #125016

nicholasbishop commented May 11, 2024 •

edited

Loading

rustbot commented May 11, 2024

rustbot commented May 11, 2024

This comment has been minimized.

rustbot commented May 12, 2024

This comment has been minimized.

klensy commented May 12, 2024

nicholasbishop commented May 12, 2024

GuillaumeGomez commented May 12, 2024

This comment has been minimized.

bors commented May 13, 2024

tgross35 commented May 16, 2024

beetrees commented May 16, 2024

This comment has been minimized.

beetrees commented May 16, 2024 •

edited

Loading

nicholasbishop commented May 16, 2024

tgross35 commented May 16, 2024

tgross35 commented May 16, 2024

Update compiler_builtins to 0.1.114 #125016

Update compiler_builtins to 0.1.114 #125016

Conversation

nicholasbishop commented May 11, 2024 • edited Loading

rustbot commented May 11, 2024

rustbot commented May 11, 2024

This comment has been minimized.

rustbot commented May 12, 2024

This comment has been minimized.

klensy commented May 12, 2024

nicholasbishop commented May 12, 2024

GuillaumeGomez commented May 12, 2024

This comment has been minimized.

bors commented May 13, 2024

tgross35 commented May 16, 2024

beetrees commented May 16, 2024

This comment has been minimized.

beetrees commented May 16, 2024 • edited Loading

nicholasbishop commented May 16, 2024

tgross35 commented May 16, 2024

tgross35 commented May 16, 2024

nicholasbishop commented May 11, 2024 •

edited

Loading

beetrees commented May 16, 2024 •

edited

Loading