[WIP] Support param bounds on non-lifetime binders #115362

compiler-errors · 2023-08-29T21:52:30Z

👀

r? @ghost

compiler-errors · 2023-08-29T21:52:37Z

@bors try @rust-timer queue

bors · 2023-08-29T21:52:46Z

⌛ Trying commit 3471faa6dbd43943bb8dc2e3bdedf59fab546439 with merge ff357375eca19961c0e26a765585b8cf4b3a1b3c...

bors · 2023-08-29T21:59:57Z

💔 Test failed - checks-actions

bors · 2023-09-03T13:50:45Z

☔ The latest upstream changes (presumably #115361) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-14T06:31:36Z

☔ The latest upstream changes (presumably #115751) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-10-18T14:25:34Z

☔ The latest upstream changes (presumably #116885) made this pull request unmergeable. Please resolve the merge conflicts.

fmease · 2023-10-19T19:07:39Z

Obviously, this is still WIP. Here's one observation I made while playing around with this patch:

trait Trait<T> {}
fn f(_: impl for<T: ?Sized> Trait<T>) {}

This successfully compiles (-Ztrait-solver=next ofc) while I don't think it should. impl for<T: ?Sized> Trait<T> isn't WF since the contained Trait<T> requires T: Sized to hold to be WF which isn't the case here. Cf: fn g<T: ?Sized>(_: impl Trait<T>) (ofc this is far from semantically equivalent) doesn't compile, rightly so.

compiler-errors · 2023-10-19T19:11:22Z

@fmease: Yeah, that's pre-existing.

#![feature(non_lifetime_binders)]

trait Trait<T> {}
fn f<S: for<T> Trait<T>>(_: S) {}
//~^ Recall that `for<T>` on stable == `for<T: ?Sized>`

This is likely due to one of the many !obligation.has_escaping_bound_vars() in wf code.

compiler-errors · 2023-12-18T17:55:28Z

@bors try @rust-timer queue

bors · 2023-12-18T17:56:38Z

⌛ Trying commit 82ae54c with merge 2e849e3...

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

bors · 2023-12-18T18:04:50Z

💔 Test failed - checks-actions

compiler-errors · 2023-12-18T18:16:20Z

@bors try @rust-timer queue

bors · 2023-12-18T18:17:30Z

⌛ Trying commit 335a142 with merge fc9bfc9...

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

bors · 2023-12-18T19:44:00Z

☀️ Try build successful - checks-actions
Build commit: fc9bfc9 (fc9bfc929cc887ed990f710b53194d68c37697d7)

rust-timer · 2023-12-18T21:19:42Z

Finished benchmarking commit (fc9bfc9): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.1%, 2.4%]	116
Regressions ❌ (secondary)	1.3%	[0.1%, 3.8%]	79
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	0.8%	[0.1%, 2.4%]	116

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.7%, 1.6%]	9
Regressions ❌ (secondary)	3.0%	[1.5%, 5.1%]	3
Improvements ✅ (primary)	-1.2%	[-2.0%, -0.7%]	3
Improvements ✅ (secondary)	-2.9%	[-5.7%, -0.9%]	7
All ❌✅ (primary)	0.4%	[-2.0%, 1.6%]	12

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.4%, 1.7%]	9
Regressions ❌ (secondary)	2.1%	[1.7%, 2.7%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.4%, 1.7%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.256s -> 682.831s (1.42%)
Artifact size: 312.47 MiB -> 313.05 MiB (0.19%)

Dylan-DPC · 2024-02-14T14:16:27Z

Closing this as it was inactive for a while and has bitrotted with a ton of conflicts plus the perf regression. Might be better starting fresh.

Dylan-DPC · 2024-02-14T14:20:14Z

ah oops then :P fair

compiler-errors · 2025-03-13T05:56:30Z

(perf is going to be absymal, but let's see)

@bors try @rust-timer queue

bors · 2025-03-13T05:57:41Z

⌛ Trying commit 513eeb3 with merge abe0bfa4da894ead245f7da89acdfcc10ab56bc9...

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

rust-log-analyzer · 2025-03-13T06:04:54Z

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
  g++ \
  make \
---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 4.072   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.079      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 88.7 MB/s eta 0:00:00
#12 4.113 Collecting filelock<4,>=3.12.2
#12 4.116   Downloading filelock-3.17.0-py3-none-any.whl (16 kB)
#12 4.148 Collecting platformdirs<5,>=3.9.1
#12 4.152   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#12 4.233 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.413 Successfully installed distlib-0.3.9 filelock-3.17.0 platformdirs-4.3.6 virtualenv-20.29.3
#12 4.414 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 DONE 4.5s

#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k:      120768 kB
DirectMap2M:     5122048 kB
DirectMap1G:    13631488 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
downloading https://static.rust-lang.org/dist/2025-02-18/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
fmt check
fmt: checked 5898 files
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_middle/src/ty/mod.rs:1001: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_hir_analysis/src/hir_ty_lowering/bounds.rs:39: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_infer/src/infer/relate/higher_ranked.rs:77: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.0.1)
linting python files
All checks passed!
checking python file formatting
26 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:48
  local time: Thu Mar 13 06:04:42 UTC 2025
  network time: Thu, 13 Mar 2025 06:04:42 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2025-03-13T08:03:19Z

☀️ Try build successful - checks-actions
Build commit: abe0bfa (abe0bfa4da894ead245f7da89acdfcc10ab56bc9)

rust-timer · 2025-03-13T09:18:52Z

Finished benchmarking commit (abe0bfa): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 5.1%]	82
Regressions ❌ (secondary)	0.8%	[0.2%, 2.3%]	50
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.2%, 5.1%]	82

Max RSS (memory usage)

Results (primary 0.9%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.6%, 4.4%]	13
Regressions ❌ (secondary)	3.1%	[1.2%, 4.8%]	7
Improvements ✅ (primary)	-1.8%	[-2.5%, -0.7%]	3
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	0.9%	[-2.5%, 4.4%]	16

Cycles

Results (primary 1.4%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.9%, 3.4%]	16
Regressions ❌ (secondary)	1.9%	[1.7%, 2.4%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[0.9%, 3.4%]	16

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.662s -> 789.655s (1.54%)
Artifact size: 365.21 MiB -> 365.67 MiB (0.13%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 29, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 29, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2023

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from 3471faa to c915474 Compare September 4, 2023 16:46

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from c915474 to 53c5310 Compare October 17, 2023 23:54

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from 53c5310 to cbe1bbd Compare October 18, 2023 00:06

This comment has been minimized.

Sign in to view

fmease mentioned this pull request Dec 18, 2023

non_lifetime_binders falsely recognizes (and rejects) trait as lifetime #119067

Closed

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from cbe1bbd to 82ae54c Compare December 18, 2023 17:55

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023

Auto merge of rust-lang#115362 - compiler-errors:non-lifetime-binder-…

2e849e3

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023

Auto merge of rust-lang#115362 - compiler-errors:non-lifetime-binder-…

fc9bfc9

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 18, 2023

Dylan-DPC closed this Feb 14, 2024

compiler-errors reopened this Feb 14, 2024

compiler-errors added 3 commits March 13, 2025 05:54

Add clauses to binders, once again

18f01e6

Implement support for binders with clauses in new solver

88e6065

Implement non-lifetime binder lowering

513eeb3

compiler-errors force-pushed the non-lifetime-binder-where-clauses branch from 335a142 to 513eeb3 Compare March 13, 2025 05:56

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025

Auto merge of rust-lang#115362 - compiler-errors:non-lifetime-binder-…

abe0bfa

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2025

[WIP] Support param bounds on non-lifetime binders #115362

Are you sure you want to change the base?

[WIP] Support param bounds on non-lifetime binders #115362

Conversation

compiler-errors commented Aug 29, 2023

compiler-errors commented Aug 29, 2023

bors commented Aug 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Aug 29, 2023

bors commented Sep 3, 2023

This comment has been minimized.

bors commented Sep 14, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Oct 18, 2023

fmease commented Oct 19, 2023 • edited Loading

compiler-errors commented Oct 19, 2023 • edited Loading

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

This comment has been minimized.

rust-timer commented Dec 18, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Dylan-DPC commented Feb 14, 2024

Dylan-DPC commented Feb 14, 2024

compiler-errors commented Mar 13, 2025

This comment has been minimized.

bors commented Mar 13, 2025

rust-log-analyzer commented Mar 13, 2025

bors commented Mar 13, 2025

This comment has been minimized.

rust-timer commented Mar 13, 2025

Overall result: ❌ regressions - please read the text below

fmease commented Oct 19, 2023 •

edited

Loading

compiler-errors commented Oct 19, 2023 •

edited

Loading