Skip to content

[BETA] Delay formatting trimmed path until lint/error is emitted #100549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BETA] Delay formatting trimmed path until lint/error is emitted #100549

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 14, 2022 •
edited
Loading

Backports #100310 #99893
cc #100542
r? @ghost

@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 14, 2022
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 14, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@compiler-errors compiler-errors changed the base branch from master to beta August 14, 2022 21:17
@compiler-errors
Copy link
Member Author

Sorry, noise was due to wrong merge base (master -> beta)

@compiler-errors compiler-errors removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 14, 2022
@compiler-errors compiler-errors changed the title Beta issue 99387 [BETA] Delay formatting trimmed path until lint/error is emitted Aug 14, 2022
@compiler-errors
Copy link
Member Author

Where the heck is the CI

@pnkfelix
Copy link
Member

discussed at T-compiler meeting.

@rustbot label: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2022
@ehuss
Copy link
Contributor

ehuss commented Aug 30, 2022

Just checking, the PR linked in the description (#100310) doesn't look correct. Is it supposed to be #99893?

@compiler-errors
Copy link
Member Author

You're right, oops.

@ehuss
Copy link
Contributor

ehuss commented Aug 31, 2022

Closing as rolled up in #101221.

@compiler-errors Just a note in terms of process. If a PR just needs a backport, the usual process is to just tag the original PR with beta-nominated. Once they are accepted, beta PRs get rolled up. It's only necessary to create a new PR if the old one does not backport cleanly, and the changes are nontrivial.

@ehuss ehuss closed this Aug 31, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 1, 2022
@compiler-errors compiler-errors deleted the beta-issue-99387 branch August 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @pnkfelix @ehuss @Mark-Simulacrum